vscode/extensions/update_installed_exts.sh: log on download failure instead of early exit#388747
Open
schuelermine wants to merge 1 commit intoNixOS:masterfrom
Open
Conversation
…nstead of early exit
github-actions
bot
added
6.topic: vscode
13 tasks
Contributor
|
What's the status of this? Can I mark it as draft? |
ghost
mentioned this pull request
13 tasks
ghost
removed their request for review
nixpkgs-ci
bot
added
the
9.needs: reviewer
nixpkgs-ci
bot
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
update_installed_exts.shscript no longer fails completely when downloading fails.This is useful if you have any extensions that aren't from the Microsoft VSCode extension marketplace.
Instead, the extension name is logged to stderr.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.