Skip to content

libvisual: drop #388447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
K900 merged 2 commits into from
Mar 9, 2025
Merged

libvisual: drop #388447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc157d1
gst_all_1.gst-plugins-base: disable libvisual
marcin-serwin Mar 9, 2025
7a4e2d4
libvisual: drop
marcin-serwin Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions pkgs/by-name/li/libvisual/package.nix
View file
Open in desktop

This file was deleted.

8 changes: 2 additions & 6 deletions pkgs/development/libraries/gstreamer/base/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
, isocodes
, libjpeg
, libpng
, libvisual
, tremor # provides 'virbisidec'
, libGL
, withIntrospection ? lib.meta.availableOn stdenv.hostPlatform gobject-introspection && stdenv.hostPlatform.emulatorAvailable buildPackages
Expand Down Expand Up @@ -97,7 +96,6 @@ stdenv.mkDerivation (finalAttrs: {
] ++ lib.optionals (!stdenv.hostPlatform.isDarwin) [
libdrm
libGL
libvisual
] ++ lib.optionals stdenv.hostPlatform.isDarwin [
OpenGL
] ++ lib.optionals enableAlsa [
Expand All @@ -124,6 +122,7 @@ stdenv.mkDerivation (finalAttrs: {
"-Dgl_winsys=${lib.concatStringsSep "," (lib.optional enableX11 "x11" ++ lib.optional enableWayland "wayland" ++ lib.optional enableCocoa "cocoa")}"
(lib.mesonEnable "introspection" withIntrospection)
(lib.mesonEnable "doc" enableDocumentation)
(lib.mesonEnable "libvisual" false)
Copy link
Contributor

@K900 K900 Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine to remove this line now.

Copy link
Contributor Author

@marcin-serwin marcin-serwin Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's enabled by default, but I'll double check

Copy link
Contributor Author

@marcin-serwin marcin-serwin Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, without this line building gst-plugins-base fails with

Run-time dependency libvisual-0.4 found: NO (tried pkgconfig)

ext/libvisual/meson.build:6:16: ERROR: Dependency "libvisual-0.4" not found, tried pkgconfig

Copy link
Contributor

@K900 K900 Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right.

] ++ lib.optionals (stdenv.buildPlatform != stdenv.hostPlatform) [
"-Dtests=disabled"
]
Expand All @@ -132,10 +131,7 @@ stdenv.mkDerivation (finalAttrs: {
++ lib.optional (!enableGl) "-Dgl=disabled"
++ lib.optional (!enableAlsa) "-Dalsa=disabled"
++ lib.optional (!enableCdparanoia) "-Dcdparanoia=disabled"
++ lib.optionals stdenv.hostPlatform.isDarwin [
"-Ddrm=disabled"
"-Dlibvisual=disabled"
];
++ lib.optional stdenv.hostPlatform.isDarwin "-Ddrm=disabled";

postPatch = ''
patchShebangs \
Expand Down