Skip to content

cudaPackages.tensorrt: remove old extension.nix#388234

Merged
prusnak merged 1 commit intoNixOS:masterfrom
ruro:delete-unused-tensorrt-files
Mar 8, 2025
Merged

cudaPackages.tensorrt: remove old extension.nix#388234
prusnak merged 1 commit intoNixOS:masterfrom
ruro:delete-unused-tensorrt-files

Conversation

@ruro
Copy link
Contributor

@ruro ruro commented Mar 8, 2025

As discussed on matrix with @ConnorBaker. All the files in pkgs/development/libraries/science/math/tensorrt were supposed to be migrated to pkgs/development/cuda-modules/tensorrt back in 8e800ce / #256324, but it looks like tensorrt/extension.nix was accidentally missed.

I don't think it is currently used anywhere in nixpkgs, so it should be safe to remove.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 8, 2025
@prusnak prusnak merged commit 360eefb into NixOS:master Mar 8, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants