Skip to content

nixos/sing-box: add configFile option#388216

Closed
oluceps wants to merge 1 commit intoNixOS:masterfrom
oluceps:singbox-file
Closed

nixos/sing-box: add configFile option#388216
oluceps wants to merge 1 commit intoNixOS:masterfrom
oluceps:singbox-file

Conversation

@oluceps
Copy link
Member

@oluceps oluceps commented Mar 8, 2025 •
edited
Loading

CC @NickCao

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 8, 2025
@oluceps oluceps added the 0.kind: enhancement Add something new or improve an existing system. label Mar 8, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 8, 2025
@oluceps oluceps requested a review from NickCao March 8, 2025 14:43
@oluceps oluceps added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 17, 2025
@Guelakais Guelakais self-requested a review April 17, 2025 17:25
@oluceps oluceps added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 17, 2025
@Guelakais Guelakais added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 17, 2025
NickCao
NickCao reviewed Apr 22, 2025
View reviewed changes
nixos/tests/sing-box.nix
{
type = "direct";
tag = "outbound:direct";
configFile = toString (
Copy link
Member

@NickCao NickCao Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test both cases?

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 9, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 25, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 20, 2025
@Guanran928
Copy link
Contributor

Guanran928 commented Oct 23, 2025

Alternative:

Should this be closed?

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 23, 2025
@oluceps oluceps closed this Oct 23, 2025
@oluceps oluceps deleted the singbox-file branch October 23, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCao NickCao NickCao left review comments

+2 more reviewers

@Guelakais Guelakais Guelakais approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.kind: enhancement Add something new or improve an existing system. 2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oluceps @Guanran928 @NickCao @Guelakais @wegank