Skip to content

tree-sitter-cpp: init at 0.23.4#387939

Closed
dadada wants to merge 1 commit intoNixOS:masterfrom
dadada:dev/add-tree-sitter-cpp
Closed

tree-sitter-cpp: init at 0.23.4#387939
dadada wants to merge 1 commit intoNixOS:masterfrom
dadada:dev/add-tree-sitter-cpp

Conversation

@dadada
Copy link
Contributor

@dadada dadada commented Mar 7, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 7, 2025
@nix-owners nix-owners bot requested a review from natsukium March 7, 2025 15:44
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 7, 2025
linsui
linsui reviewed Mar 11, 2025
View reviewed changes
Aleksanaa
Aleksanaa reviewed Mar 11, 2025
View reviewed changes
@dadada dadada force-pushed the dev/add-tree-sitter-cpp branch from b921186 to 69164ba Compare March 16, 2025 18:19
@dadada dadada force-pushed the dev/add-tree-sitter-cpp branch from 69164ba to 0d8deee Compare March 16, 2025 18:19
@dadada dadada requested a review from Aleksanaa March 16, 2025 18:19
@ambroisie
Copy link
Contributor

ambroisie commented Mar 20, 2025

Should be superseded by #320783 which takes care of all grammars.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 16, 2025
@teto teto added the 6.topic: tree-sitter Tree-sitter is a parser generator tool and an incremental parsing library. label Dec 7, 2025
@uncenter
Copy link
Member

uncenter commented Dec 17, 2025

@dadada can you confirm that #320783 (merged a month after this was created fwiw) resolves this issue without the need for this pull request?

@dadada dadada closed this Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natsukium natsukium Awaiting requested review from natsukium

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

1 more reviewer

@linsui linsui linsui left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: tree-sitter Tree-sitter is a parser generator tool and an incremental parsing library. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dadada @ambroisie @uncenter @linsui @Aleksanaa @teto