Skip to content

postgresqlPackages.pg_tle: init at 1.4.0#387868

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
BenChand:benc/pg_tle
Mar 7, 2025
Merged

postgresqlPackages.pg_tle: init at 1.4.0#387868
wolfgangwalther merged 1 commit intoNixOS:masterfrom
BenChand:benc/pg_tle

Conversation

@BenChand
Copy link
Contributor

@BenChand BenChand commented Mar 7, 2025

Things done

Tested as an extension in private repo on aarch64-linux and aarch64-darwin

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 7, 2025
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High-level question, but not blocking:

This extension allows installing more extensions non-declaratively...

... is this really what we want in the context of nixpkgs? Somehow our goal is the exact opposite, right?

@BenChand
Copy link
Contributor Author

BenChand commented Mar 7, 2025

High-level question, but not blocking:

This extension allows installing more extensions non-declaratively...

... is this really what we want in the context of nixpkgs? Somehow our goal is the exact opposite, right?

I'm not too sure what the best approach would be but I can outline my use-case - I'm working with a private postgres extension that is build outside of the nix ecosystem and is installed via pg_tle. I want to run integration tests through nix which requires spinning up a postgres instance during the build process, which requires the pg_tle extension to be present. If it's not suitable for nixpkgs I can close.

@wolfgangwalther
Copy link
Contributor

I'm not too sure what the best approach would be but I can outline my use-case - I'm working with a private postgres extension that is build outside of the nix ecosystem and is installed via pg_tle. I want to run integration tests through nix which requires spinning up a postgres instance during the build process, which requires the pg_tle extension to be present.

Yeah, makes sense. You could always package this extension up for nix in a private overlay, but this wouldn't help for integration testing with pg_tle.

If it's not suitable for nixpkgs I can close.

It is, no worries - as I said: non-blocking. All pg extensions are suitable for nixpkgs, imho.

@wolfgangwalther
Copy link
Contributor

Please squash all the commits into the first one, too.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 7, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 7, 2025
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 387868


x86_64-linux

✅ 10 packages built:
  • postgresql13JitPackages.pg_tle
  • postgresql13Packages.pg_tle
  • postgresql14JitPackages.pg_tle
  • postgresql14Packages.pg_tle
  • postgresql15JitPackages.pg_tle
  • postgresql15Packages.pg_tle
  • postgresql16JitPackages.pg_tle
  • postgresql16Packages.pg_tle
  • postgresqlJitPackages.pg_tle (postgresql17JitPackages.pg_tle)
  • postgresqlPackages.pg_tle (postgresql17Packages.pg_tle)

aarch64-linux

✅ 10 packages built:
  • postgresql13JitPackages.pg_tle
  • postgresql13Packages.pg_tle
  • postgresql14JitPackages.pg_tle
  • postgresql14Packages.pg_tle
  • postgresql15JitPackages.pg_tle
  • postgresql15Packages.pg_tle
  • postgresql16JitPackages.pg_tle
  • postgresql16Packages.pg_tle
  • postgresqlJitPackages.pg_tle (postgresql17JitPackages.pg_tle)
  • postgresqlPackages.pg_tle (postgresql17Packages.pg_tle)

x86_64-darwin

✅ 10 packages built:
  • postgresql13JitPackages.pg_tle
  • postgresql13Packages.pg_tle
  • postgresql14JitPackages.pg_tle
  • postgresql14Packages.pg_tle
  • postgresql15JitPackages.pg_tle
  • postgresql15Packages.pg_tle
  • postgresql16JitPackages.pg_tle
  • postgresql16Packages.pg_tle
  • postgresqlJitPackages.pg_tle (postgresql17JitPackages.pg_tle)
  • postgresqlPackages.pg_tle (postgresql17Packages.pg_tle)

aarch64-darwin

✅ 10 packages built:
  • postgresql13JitPackages.pg_tle
  • postgresql13Packages.pg_tle
  • postgresql14JitPackages.pg_tle
  • postgresql14Packages.pg_tle
  • postgresql15JitPackages.pg_tle
  • postgresql15Packages.pg_tle
  • postgresql16JitPackages.pg_tle
  • postgresql16Packages.pg_tle
  • postgresqlJitPackages.pg_tle (postgresql17JitPackages.pg_tle)
  • postgresqlPackages.pg_tle (postgresql17Packages.pg_tle)

@wolfgangwalther wolfgangwalther changed the title pg_tle: init at v1.4.0 postgresqlPackages.pg_tle: init at v1.4.0 Mar 7, 2025
@wolfgangwalther wolfgangwalther changed the title postgresqlPackages.pg_tle: init at v1.4.0 postgresqlPackages.pg_tle: init at 1.4.0 Mar 7, 2025
@wolfgangwalther wolfgangwalther merged commit 8079fb4 into NixOS:master Mar 7, 2025
41 of 43 checks passed
@wolfgangwalther
Copy link
Contributor

Thanks!

@BenChand BenChand deleted the benc/pg_tle branch March 7, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants