Merged
Conversation
Member
|
please rebase, we now get an eval error |
marcin-serwin
requested changes
Jun 28, 2025
Contributor
marcin-serwin
left a comment
There was a problem hiding this comment.
libxmp was already added in #402066, but I didn't know that it replaces libmodplug. You can fix the eval by modifying the PR to just drop the latter.
Upstream prefers libxmp over libmodplug now. Also, the package wasn't working with libmodplug, because it needs a build flag to build with libmodplug support in place of libxmp. It could be an option if someone is interested in implementing
Member
|
I rebased it |
marcin-serwin
approved these changes
Jun 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream prefers libxmp over libmodplug now. Also, the package wasn't working with libmodplug, because it needs a build flag to build with libmodplug support in place of libxmp. It could be an option if someone is interested in implementing.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.