i3status-rust: make notmuch optional

[just1602]

Hello,

With notmuch recently failling to build, it makes i3status-rust failling to build too. This PR make it possible to disable notmuch support if desire.

I'm currently using this patch as an overlay on my config and it works perfectly fine.

My editor has nixd configured for lsp and it format on save, so it format the file using nixfmt-rfc-style, I assume it is ok, but if it's not I'll revert those modification and only add the bits to make notmuch optional.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[drupol]

With notmuch recently failling to build, it makes i3status-rust failling to build too.

I guess this PR is not going to fix that issue since withNotMuch is enabled by default. Right?

Tip for the next time: make sure to correctly separate your commits, especially when there are reformatting commits like in this PR. Without that, it makes the review much harder.

[just1602]

@drupol as I said in the other PR, no it doesn't disable it by default because I didn't want to break the current behavior, but I want to make it possible for people to override the attribute and disable it if needed.

Otherwise, a lot of people who use notmuch will upgrade and get their mail setup broken without any notice, that wouldn't make sense.

[drupol]

The diff LGTM, though I would have preferred separate commits.

Note: This PR does not fix i3status-rust; it only adds a flag to disable notmuch, which is the underlying issue preventing i3status-rust from building correctly.

While this is merely a workaround rather than a true fix, I’m okay with this change since the default flag value remains unchanged, meaning the real issue still needs to be addressed. That said, having the option to disable notmuch via a flag is a useful addition.

Edit: Fixed in #386681

[drupol]

@just1602 I see that the CI succeeded to build i3status-rust correctly on x86_64-linux and aarch64-linux.

In your original message, you mention:

With notmuch recently failling to build, it makes i3status-rust failling to build too.

Can you please let us know more? Which arch/platform is failing for you?

[mhutter]

@drupol see #386681

[just1602]

@drupol before #386738 got merged, every package that were relying on notmuch failed to build. This patch make it possible to disable notmuch support for people who don't use it or want to override neomutt attrs to make it build anyways even if notmuch doesn't build again.

@mhutter beat me

[GaetanLepage]

Please, definitely split the patch. Formatting should happen in a different commit.