Conversation
They are affected by CVEs which are fixed in Emacs 30.
They are affected by CVEs which are fixed in Emacs 30.
nix-owners
bot
requested review from
AndersonTorres,
adisbladis,
matthewbauer and
ttuegel
github-actions
bot
added
10.rebuild-darwin: 0
|
I was wondering if it would make sense to get rid of the |
When we enabled native-comp by default, we turn Turning old aliases into |
|
|
||
| # Emacs | ||
| emacs28 = throw "Emacs 28 is removed due to CVEs which are fixed in Emacs 30"; # Added 2025-03-03 | ||
| emacs28-gtk2 = throw "emacs28-gtk2 was removed because GTK2 is EOL; migrate to emacs28{,-gtk3,-nox} or to more recent versions of Emacs."; # Added 2024-09-20 |
There was a problem hiding this comment.
Nit: reword this message so that no one gets it wrong by accident.
There was a problem hiding this comment.
Which part may be confusing? Would it be better to remove which are fixed in Emacs 30?
There was a problem hiding this comment.
emacs28-gtk2 = throw "Emacs 28 is removed due to CVEs which are fixed in Emacs 30"; # Added 2024-09-20Supposing someone did not update their system in a long heck of time, the "update to emacs29 or use other toolkit" message can be misleading.
There was a problem hiding this comment.
Oh, you are referring to the emacs28-gtk2 alias which is not touched by this PR.
If a user of that emacs28-gtk2 alias switches to emacs28 or emacs28-gtk3, he will follow instructions added by this PR to use emacs 30. Yes, it is not great for a user to have to change attr twice, but I do not think it is confusing/misleading.
|
Since this PR essentially deletes Emacs < 30, should the old patches be deleted accordingly, whether now or in the future? Edit: answering myself, I think it would be better to remove all code that refers to old versions in a future PR. |
wegank
added
12.approved-by: package-maintainer
'emacs29' is no longer provided by nixpkgs¹ in the currently supported branches, with the exception of 'emacs-macport', at 29.4. Also, 'emacs-pgtk' is available, providing a convenient, current and version-neutral symbol. ¹: NixOS/nixpkgs#386593 ²: NixOS/nixpkgs#396416
'emacs29' is no longer provided by nixpkgs¹ in the currently supported branches, with the exception of 'emacs-macport', at 29.4. Also, 'emacs-pgtk' is available, providing a convenient, current and version-neutral symbol. ¹: NixOS/nixpkgs#386593 ²: NixOS/nixpkgs#396416
4 participants
I'll add release notes in a future PR so that this PR can be backported by bot.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.