Skip to content

treewide: finalAttrs.doCheck -> finalAttrs.finalPackage.doCheck#386590

Merged
pbsds merged 1 commit intoNixOS:masterfrom
pbsds:migrate-finalAttrs-doCheck-1740976093
Mar 9, 2025
Merged

treewide: finalAttrs.doCheck -> finalAttrs.finalPackage.doCheck#386590
pbsds merged 1 commit intoNixOS:masterfrom
pbsds:migrate-finalAttrs-doCheck-1740976093

Conversation

@pbsds
Copy link
Member

@pbsds pbsds commented Mar 3, 2025

repeat of #271241, part of #346453

should be 0 rebuilds

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: cuda Parallel computing platform and API 6.topic: flutter Open-source UI software development kit for cross-platform applications labels Mar 3, 2025
@pbsds pbsds force-pushed the migrate-finalAttrs-doCheck-1740976093 branch from ae0076c to 7972442 Compare March 3, 2025 04:40
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 6.topic: cuda Parallel computing platform and API labels Mar 3, 2025
@pbsds pbsds merged commit 23e80e4 into NixOS:master Mar 9, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from New to ✅ Done in CUDA Team Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: flutter Open-source UI software development kit for cross-platform applications 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant