buildPython*: simplify check-related attribute inheritance#386489
Merged
ShamrockLee merged 1 commit intoNixOS:stagingfrom Mar 9, 2025
Merged
buildPython*: simplify check-related attribute inheritance#386489ShamrockLee merged 1 commit intoNixOS:stagingfrom
ShamrockLee merged 1 commit intoNixOS:stagingfrom
Conversation
13 tasks
fdcfa71 to
8729bfc
Compare
8729bfc to
55d08bb
Compare
wolfgangwalther
approved these changes
Mar 9, 2025
Contributor
wolfgangwalther
left a comment
There was a problem hiding this comment.
Just read through it, didn't build, but LGTM.
Contributor
Author
|
@ofborg build python3Packages.pytestCheckHook.tests |
Contributor
Author
|
OfBorg's Linux machines build I'll merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the inheritance of check-related attributes. It essentially pass these arguments directly whenever
attrs.doCheckis true or unspecified.This PR is implemented with a local helper function
getExistingAttrs, which is likegetAttrsbut ignores non-existing attributes. This helps reduce boilerplate codes, and subsequent PRs will also utilize such helper function.This can be seen as the non-controvertial, backward-compatible part of #376060.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.