Skip to content

xdg-desktop-portal-cosmic: 1.0.0-alpha.5.1 -> 1.0.0-alpha.6#386198

Merged
JohnRTitor merged 9 commits intoNixOS:masterfrom
HeitorAugustoLN:bump/xdg-desktop-portal-cosmic
Mar 3, 2025
Merged

xdg-desktop-portal-cosmic: 1.0.0-alpha.5.1 -> 1.0.0-alpha.6#386198
JohnRTitor merged 9 commits intoNixOS:masterfrom
HeitorAugustoLN:bump/xdg-desktop-portal-cosmic

Conversation

@HeitorAugustoLN
Copy link
Member

@HeitorAugustoLN HeitorAugustoLN commented Mar 1, 2025 •
edited
Loading

  • Remove vendored Cargo.lock that was forgotten to be removed
  • Fix service execution
  • xdg-desktop-portal-cosmic is now using libcosmicAppHook
  • Modernized the package
  • Added myself as one of the maintainers of the package
  • Updated it from 1.0.0-alpha.5.1 to 1.0.0-alpha.6
  • Added an updateScript

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 1, 2025
@nix-owners nix-owners bot requested review from a-kenji and nyabinary March 1, 2025 20:25
a-kenji
a-kenji approved these changes Mar 2, 2025
View reviewed changes
Copy link
Member

@a-kenji a-kenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not happy about the usage of the libcosmicAppHook without proper documentation for it first akin to how the Gnome Hooks are documented.

So I personally prefer that being done first, or at least in a follow up PR.

The rest looks good.

@HeitorAugustoLN
Copy link
Member Author

HeitorAugustoLN commented Mar 2, 2025

Not happy about the usage of the libcosmicAppHook without proper documentation for it first akin to how the Gnome Hooks are documented.

So I personally prefer that being done first, or at least in a follow up PR.

I can write documentation for it tomorrow in another PR

@nyabinary
Copy link
Contributor

nyabinary commented Mar 3, 2025

Shouldn't this switch to using finalAttrs as well since support for rust got added here: #382550 ?

@a-kenji
Copy link
Member

a-kenji commented Mar 3, 2025

Just because the support got added doesn't mean everything has to be done in one PR imho. But generally that would not be a bad idea, yes.

@HeitorAugustoLN
Copy link
Member Author

HeitorAugustoLN commented Mar 3, 2025

Shouldn't this switch to using finalAttrs as well since support for rust got added here: #382550 ?

Didn't know about that! That is cool, I can switch to it

@nyabinary
Copy link
Contributor

nyabinary commented Mar 3, 2025

Shouldn't this switch to using finalAttrs as well since support for rust got added here: #382550 ?

Didn't know about that! That is cool, I can switch to it

Maybe switch to finalAttrs in your other prs :3 if you can

@a-kenji
Copy link
Member

a-kenji commented Mar 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386198

x86_64-linux

❌ 3 packages failed to build:
  • cosmic-session
  • xdg-desktop-portal-cosmic
  • xdg-desktop-portal-cosmic.debug

@HeitorAugustoLN
Copy link
Member Author

HeitorAugustoLN commented Mar 3, 2025

This is odd, it wasn't failing before

@a-kenji
Copy link
Member

a-kenji commented Mar 3, 2025

Maybe it is a me thing? Can you try building it?

@HeitorAugustoLN
Copy link
Member Author

HeitorAugustoLN commented Mar 3, 2025 •
edited
Loading

Maybe it is a me thing? Can you try building it?

I did built it, it is failing now. ofborg builds is also failing.
It because of the checkPhase, something is off. I am checking on that.

@HeitorAugustoLN
Copy link
Member Author

HeitorAugustoLN commented Mar 3, 2025 •
edited
Loading

I got it. It will need a patch, I really don't know why it wasn't happening before.

@HeitorAugustoLN
Copy link
Member Author

HeitorAugustoLN commented Mar 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386198

x86_64-linux

✅ 3 packages built:
  • cosmic-session
  • xdg-desktop-portal-cosmic
  • xdg-desktop-portal-cosmic.debug

1 similar comment
@a-kenji
Copy link
Member

a-kenji commented Mar 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386198

x86_64-linux

✅ 3 packages built:
  • cosmic-session
  • xdg-desktop-portal-cosmic
  • xdg-desktop-portal-cosmic.debug

@HeitorAugustoLN HeitorAugustoLN added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Mar 3, 2025
@HeitorAugustoLN
xdg-desktop-portal-cosmic: fix package tests after ashpd API updates
a7cb4b5 
Apply upstream patch to fix compilation errors in example code that were causing
test failures. The issues were related to API changes in the ashpd dependency
@HeitorAugustoLN HeitorAugustoLN force-pushed the bump/xdg-desktop-portal-cosmic branch from f935eda to a7cb4b5 Compare March 3, 2025 13:22
@JohnRTitor
Copy link
Member

JohnRTitor commented Mar 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386198

x86_64-linux

✅ 3 packages built:
  • cosmic-session
  • xdg-desktop-portal-cosmic
  • xdg-desktop-portal-cosmic.debug

@HeitorAugustoLN HeitorAugustoLN added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 3, 2025
@JohnRTitor JohnRTitor merged commit 8ccc251 into NixOS:master Mar 3, 2025
58 of 60 checks passed
@HeitorAugustoLN HeitorAugustoLN deleted the bump/xdg-desktop-portal-cosmic branch March 3, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnRTitor JohnRTitor JohnRTitor approved these changes

@nyabinary nyabinary Awaiting requested review from nyabinary

+1 more reviewer

@a-kenji a-kenji a-kenji approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HeitorAugustoLN @nyabinary @a-kenji @JohnRTitor