Skip to content

vscode-extensions.bmewburn.vscode-intelephense-client: 1.12.5 -> 1.14.1#385877

Merged
drupol merged 1 commit intoNixOS:masterfrom
patka-123:push-kqtmnnmqxuzq
Feb 28, 2025
Merged

vscode-extensions.bmewburn.vscode-intelephense-client: 1.12.5 -> 1.14.1#385877
drupol merged 1 commit intoNixOS:masterfrom
patka-123:push-kqtmnnmqxuzq

Conversation

@patka-123
Copy link
Contributor

@patka-123 patka-123 commented Feb 28, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 28, 2025
@nix-owners nix-owners bot requested a review from drupol February 28, 2025 19:27
@drupol
Copy link
Contributor

drupol commented Feb 28, 2025

I just check with a script of my own (#384899 (comment)) and it looks good.

❯ ./ext.sh bmewburn.vscode-intelephense-client
102 extension version(s) found for bmewburn.vscode-intelephense-client
102 extension version(s) found after filtering for compatibility with VSCode 1.97.2
VSCode version: 1.97.2
Selected extension version: 1.14.1
❯

On another note, I think we should move this extension to its own directory to get it automatically updated by the bot.

@drupol drupol merged commit fb39faf into NixOS:master Feb 28, 2025
58 of 59 checks passed
@patka-123 patka-123 deleted the push-kqtmnnmqxuzq branch February 28, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants