Merged
Conversation
When setting up interrupt remapping for legacy PCI(-X) devices,
including PCI(-X) bridges, a lookup of the upstream bridge is required.
This lookup, itself involving acquiring of a lock, is done in a context
where acquiring that lock is unsafe. This can lead to a deadlock.
The passing through of certain kinds of devices to an unprivileged guest
can result in a Denial of Service (DoS) affecting the entire host.
Note: Normal usage of such devices by a privileged domain can also
trigger the issue. In such a scenario, the deadlock is not
considered a security issue, but just a plain bug.
Systems with Intel IOMMU hardware (VT-d) are affected. Systems using
AMD or non-x86 hardware are not affected.
Only systems where certain kinds of devices are passed through to an
unprivileged guest are vulnerable.
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
SigmaSquadron
added
1.severity: security
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
CertainLach
approved these changes
Feb 27, 2025
hehongbo
approved these changes
Feb 28, 2025
wegank
added
the
12.approvals: 2
LeSuisse
approved these changes
Mar 1, 2025
Member
LeSuisse
left a comment
LeSuisse
left a comment
There was a problem hiding this comment.
Minimal security patch, nixpkgs-review looks good.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 385642
x86_64-linux
⏩ 1 package marked as broken and skipped:
- qubes-core-vchan-xen
❌ 3 packages failed to build:
- htcondor
- python313Packages.guestfs
- python313Packages.guestfs.dist
✅ 60 packages built:
- appvm
- collectd
- diffoscope
- diffoscope.dist
- diffoscope.man
- docker-machine-kvm2
- fdroidserver
- fdroidserver.dist
- gnome-boxes
- libguestfs
- libguestfs.guestfsd
- librenms
- libvirt
- libvirt-glib
- libvirt-glib.dev
- libvirt-glib.devdoc
- libvmi
- libvmi.dev
- libvmi.lib
- mgmt
- minikube
- multipass
- perl538Packages.SysVirt
- perl538Packages.SysVirt.devdoc
- perl540Packages.SysVirt
- perl540Packages.SysVirt.devdoc
- prometheus-libvirt-exporter
- python312Packages.guestfs
- python312Packages.guestfs.dist
- python312Packages.libvirt
- python312Packages.libvirt.dist
- xen (python312Packages.xen)
- xen.boot (python312Packages.xen.boot)
- xen.dev (python312Packages.xen.dev)
- xen.doc (python312Packages.xen.doc)
- xen.man (python312Packages.xen.man)
- python313Packages.libvirt
- python313Packages.libvirt.dist
- python313Packages.xen
- python313Packages.xen.boot
- python313Packages.xen.dev
- python313Packages.xen.doc
- python313Packages.xen.man
- qemu_xen
- qemu_xen.debug
- qemu_xen.doc
- qemu_xen.ga
- rubyPackages.ruby-libvirt (rubyPackages_3_3.ruby-libvirt)
- rubyPackages_3_1.ruby-libvirt
- rubyPackages_3_2.ruby-libvirt
- rubyPackages_3_4.ruby-libvirt
- vagrant
- virt-manager
- virt-manager-qt
- virt-top
- virt-v2v
- virt-viewer
- virtnbdbackup
- virtnbdbackup.dist
- xen-guest-agent
This was referenced May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://xenbits.xenproject.org/xsa/advisory-467.html
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.