Skip to content

yazi-unwrapped: 25.2.11 -> 25.2.26#385283

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
FlameFlag:update-yazi
Feb 27, 2025
Merged

yazi-unwrapped: 25.2.11 -> 25.2.26#385283
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
FlameFlag:update-yazi

Conversation

@FlameFlag
Copy link
Member

@FlameFlag FlameFlag commented Feb 26, 2025

Breaking Changes

Things done

Changelog: https://github.com/sxyazi/yazi/releases/tag/v25.2.26
Diff: sxyazi/yazi@v25.2.11...v25.2.26

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 26, 2025
@ddogfoodd
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 385283


x86_64-linux

✅ 2 packages built:
  • yazi
  • yazi-unwrapped

Copy link
Contributor

@ddogfoodd ddogfoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the env.VERGEN_BUILD_DATE in line 44 require an update as well?

Other than that, builds and works fine for me on x86_64-linux, thanks

@FlameFlag
Copy link
Member Author

does the env.VERGEN_BUILD_DATE in line 44 require an update as well?

Yeap you're right

@uncenter
Copy link
Member

does the env.VERGEN_BUILD_DATE in line 44 require an update as well?

Yeap you're right

Fwiw the update script should be handling this? Might be better to use that in the future :)

@uncenter
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 385283


aarch64-darwin

✅ 2 packages built:
  • yazi
  • yazi-unwrapped

@uncenter uncenter added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 26, 2025
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 385283


x86_64-linux

✅ 2 packages built:
  • yazi
  • yazi-unwrapped

aarch64-linux

✅ 2 packages built:
  • yazi
  • yazi-unwrapped

x86_64-darwin

✅ 2 packages built:
  • yazi
  • yazi-unwrapped

aarch64-darwin

✅ 2 packages built:
  • yazi
  • yazi-unwrapped

@eljamm eljamm added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 26, 2025
@ddogfoodd
Copy link
Contributor

Fwiw the update script should be handling this? Might be better to use that in the future :)

Thanks, good to know. Can one just run that or do we have to wait for the bot? Just asking in case there is an important bugfix or change in one release, so that people might not want to wait.

@FliegendeWurst FliegendeWurst changed the title yazi-unwrapped: 25.2.11 -> 22.2.26 yazi-unwrapped: 25.2.11 -> 25.2.26 Feb 26, 2025
@uncenter
Copy link
Member

Can one just run that or do we have to wait for the bot?

One can run nix run nixpkgs#nix-update -- yazi-unwrapped -u, but it actually seems like the update script is running into a bit of a jam at the moment.

Update script error

Crashing on this part:

++ nix-prefetch '{ sha256 }: (import /Users/uncenter/Dev/Forks/nixpkgs {}).yazi-unwrapped.cargoDeps.overrideAttrs (_: { outputHash = sha256; })'
error:
       … while calling the 'zipAttrsWith' builtin
         at /nix/store/4yng3wz3ri8q2g64aysa72j1n3dsa0i2-source/lib/attrsets.nix:1578:8:
         1577|       );
         1578|     in f [] [rhs lhs];
             |        ^
         1579|

       … while evaluating a branch condition
         at /nix/store/4yng3wz3ri8q2g64aysa72j1n3dsa0i2-source/lib/attrsets.nix:1352:5:
         1351|     as:
         1352|     if cond then as else {};
             |     ^
         1353|

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: expected a set but found null: null
+ cargoHash=

Last time the update script was updated was before useFetchCargoVendor was enabled, maybe that is messing with it?

@FlameFlag
Copy link
Member Author

Fwiw the update script should be handling this? Might be better to use that in the future :)

I initially tried to use the script with nix-shell ./maintainers/scripts/update.nix --argstr package yazi-unwrapped --argstr skip-prompt true, but I ran into the same issue as described in #385283 (comment), so I did the update manually

@eljamm
Copy link
Contributor

eljamm commented Feb 26, 2025

Yea, the update script silently broke a while ago I guess, but I've been working on fixing it in #385409.

@wegank wegank removed the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Feb 26, 2025
@XYenon
Copy link
Member

XYenon commented Feb 27, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 385283


x86_64-linux

✅ 2 packages built:
  • yazi
  • yazi-unwrapped

@uncenter
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 385283


aarch64-darwin

✅ 2 packages built:
  • yazi
  • yazi-unwrapped

@uncenter uncenter added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Feb 27, 2025
@eljamm eljamm added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Feb 27, 2025
@SuperSandro2000 SuperSandro2000 merged commit d035fb3 into NixOS:master Feb 27, 2025
28 of 29 checks passed
@FlameFlag FlameFlag deleted the update-yazi branch February 27, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants