mlkit: set dontCheckForBrokenSymlinks#385089
Merged
ConnorBaker merged 1 commit intoNixOS:masterfrom Mar 1, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 1-10
13 tasks
ConnorBaker
reviewed
Mar 1, 2025
athas
force-pushed
the
mlkit-broken-symlinks
branch
from
d6798d3 to
f90fbe9
Compare
Contributor
Author
|
Installing the test suite is part of the upstream vision for some reason, and I'd rather not change it. |
ConnorBaker
approved these changes
Mar 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the mlkit derivation is broken. This fixes it. The broken symlinks are by upstream design.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.