Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ripes: fix build on darwin, move to by-name #384821

Merged
merged 2 commits into from
Feb 25, 2025
Merged

ripes: fix build on darwin, move to by-name #384821

merged 2 commits into from
Feb 25, 2025
+13 −10

Conversation

WeetHet
Copy link
Contributor

@WeetHet WeetHet commented Feb 24, 2025

Closes #384818

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 24, 2025
@WeetHet WeetHet force-pushed the fix-ripes branch 3 times, most recently from d51dcee to da3f3f4 Compare February 25, 2025 11:28
Kamillaova
Kamillaova approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@Kamillaova Kamillaova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WeetHet WeetHet requested a review from wineee February 25, 2025 11:46
@WeetHet WeetHet requested a review from Kamillaova February 25, 2025 11:51
Kamillaova
Kamillaova approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@Kamillaova Kamillaova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, successfully built on aarch64-linux

@wineee wineee merged commit 8a5c383 into NixOS:master Feb 25, 2025
24 of 27 checks passed
@WeetHet WeetHet deleted the fix-ripes branch February 25, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Kamillaova Kamillaova Kamillaova approved these changes

@wineee wineee Awaiting requested review from wineee

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: ripes
4 participants
@WeetHet @SuperSandro2000 @wineee @Kamillaova