-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
melonloader-installer: init at 4.1.1 #384656
base: release-24.11
Are you sure you want to change the base?
melonloader-installer: init at 4.1.1 #384656
Conversation
c958b7e
to
85d60c2
Compare
https://github.com/LavaGang/MelonLoader.Installer/releases/tag/4.1.1 melonloader-installer: implement feedback from nixfmt melonloader-installer: make platforms a list
85d60c2
to
c4fa4a3
Compare
src = fetchFromGitHub { | ||
owner = "LavaGang"; | ||
repo = "MelonLoader.Installer"; | ||
rev = version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rev = version; | |
tag = version; |
|
||
passthru.updateScript = gitUpdater { }; | ||
|
||
meta = with lib; { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta = with lib; { | |
meta = { |
homepage = "https://melonwiki.xyz"; | ||
mainProgram = "MelonLoader.Installer.Linux"; | ||
description = "Automated installer for MelonLoader, the universal mod-loader for games built in the Unity Engine"; | ||
license = licenses.asl20; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license = licenses.asl20; | |
license = lib.licenses.asl20; |
description = "Automated installer for MelonLoader, the universal mod-loader for games built in the Unity Engine"; | ||
license = licenses.asl20; | ||
platforms = [ "x86_64-linux" ]; | ||
maintainers = with maintainers; [ WillemToorenburgh ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainers = with maintainers; [ WillemToorenburgh ]; | |
maintainers = with lib.maintainers; [ WillemToorenburgh ]; |
Hello! This is my first working attempt at packaging something for Nix(OS) after a few false starts. MelonLoader.Installer seemed like a good choice to try, as their team had just added Linux support as of version 4.1.0.
MelonLoader.Installer is a small utility that lets users easily install their chosen version of MelonLoader into Unity Engine games installed on the user's machine. It is capable of auto-detecting games, and was able to do so successfully on my NixOS installation.
The package is about as simple as it gets: a Dotnet program built with almost all the defaults from the Wiki. I set
selfContainedBuild = true
as that is what it seemed like the code wanted. I was able to verify that the program works as expected, successfully installing MelonLoader DLLs into Neon White.As this is a new package, and I developed it on NixOS 24.11, it should be appropriate for backporting, but I'm not sure how to initiate that process just yet.
Output of
nix-instantiate --eval -A lib.trivial.oldestSupportedRelease
:2405
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.