Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

melonloader-installer: init at 4.1.1 #384656

Open
wants to merge 2 commits into
base: release-24.11
Choose a base branch
from

Conversation

WillemToorenburgh
Copy link

Hello! This is my first working attempt at packaging something for Nix(OS) after a few false starts. MelonLoader.Installer seemed like a good choice to try, as their team had just added Linux support as of version 4.1.0.

MelonLoader.Installer is a small utility that lets users easily install their chosen version of MelonLoader into Unity Engine games installed on the user's machine. It is capable of auto-detecting games, and was able to do so successfully on my NixOS installation.

The package is about as simple as it gets: a Dotnet program built with almost all the defaults from the Wiki. I set selfContainedBuild = true as that is what it seemed like the code wanted. I was able to verify that the program works as expected, successfully installing MelonLoader DLLs into Neon White.

As this is a new package, and I developed it on NixOS 24.11, it should be appropriate for backporting, but I'm not sure how to initiate that process just yet.

Output of nix-instantiate --eval -A lib.trivial.oldestSupportedRelease: 2405

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Feb 24, 2025
@WillemToorenburgh WillemToorenburgh changed the base branch from nixos-24.11 to release-24.11 February 24, 2025 02:16
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Feb 24, 2025
@WillemToorenburgh WillemToorenburgh force-pushed the add-melonloader-installer branch from c958b7e to 85d60c2 Compare February 24, 2025 04:16
https://github.com/LavaGang/MelonLoader.Installer/releases/tag/4.1.1

melonloader-installer: implement feedback from nixfmt

melonloader-installer: make platforms a list
@WillemToorenburgh WillemToorenburgh force-pushed the add-melonloader-installer branch from 85d60c2 to c4fa4a3 Compare February 24, 2025 04:23
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 24, 2025
src = fetchFromGitHub {
owner = "LavaGang";
repo = "MelonLoader.Installer";
rev = version;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = version;
tag = version;


passthru.updateScript = gitUpdater { };

meta = with lib; {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with lib; {
meta = {

homepage = "https://melonwiki.xyz";
mainProgram = "MelonLoader.Installer.Linux";
description = "Automated installer for MelonLoader, the universal mod-loader for games built in the Unity Engine";
license = licenses.asl20;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license = licenses.asl20;
license = lib.licenses.asl20;

description = "Automated installer for MelonLoader, the universal mod-loader for games built in the Unity Engine";
license = licenses.asl20;
platforms = [ "x86_64-linux" ];
maintainers = with maintainers; [ WillemToorenburgh ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = with maintainers; [ WillemToorenburgh ];
maintainers = with lib.maintainers; [ WillemToorenburgh ];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants