Skip to content

niri: remove XDG_RUNTIME_DIR in check phase#384634

Merged
r-vdp merged 1 commit intoNixOS:masterfrom
sodiboo:niri
Feb 24, 2025
Merged

niri: remove XDG_RUNTIME_DIR in check phase#384634
r-vdp merged 1 commit intoNixOS:masterfrom
sodiboo:niri

Conversation

@sodiboo
Copy link
Member

@sodiboo sodiboo commented Feb 24, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 24, 2025
@Defelo
Copy link
Member

Defelo commented Feb 24, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 384634

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/13500824093

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-384634-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/03jpyvc7mnzmm3a6bipfcl2vwccs3d6h-niri-25.02 \
      /nix/store/jhrbn5v413nr8b9lbg0r729fjl8j8skw-stardust-xr-kiara-0-unstable-2024-07-13
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-384634-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/m3fwi4l2b6phyd6cn58ifr3v1ziiv95h-niri-25.02 \
      /nix/store/j7jr7g00kgmhpvaww29jxj510917i8m1-stardust-xr-kiara-0-unstable-2024-07-13

x86_64-linux

✅ 2 packages built:
  • niri
  • stardust-xr-kiara

aarch64-linux

✅ 2 packages built:
  • niri
  • stardust-xr-kiara

@r-vdp r-vdp merged commit 5b5bd96 into NixOS:master Feb 24, 2025
26 of 27 checks passed
@sodiboo sodiboo mentioned this pull request Feb 25, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants