plasticity: fix build#384389
plasticity: fix build#384389FliegendeWurst merged 3 commits intoNixOS:masterfrom AmazinAxel:fix-plasticity-build
Conversation
|
I clicked the Sync Fork button on github and it added an additional commit - new to git so I don't know how to revert that |
So it doesn't have a report on failure? Or you can use |
It does have an error for each of the broken symlinks but I don't know what to do with that information. We could simply delete those symlinks but I don't know if that's the best course of action. For now to fix the build error, we can just skip the hook. If you think we should delete the symlinks instead I can make a new PR or update this PR |
Plasticity was not building after this commit. This change fixes the build by enabling
dontCheckForBrokenSymlinksbut this is a band-aid solution. Someone with more time and experience should go through to try fixing the symlinks, but this will fix the build in the meantime. The application works the same as before.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.