Skip to content

plasticity: fix build#384389

Merged
FliegendeWurst merged 3 commits intoNixOS:masterfrom
AmazinAxel:fix-plasticity-build
Mar 25, 2025
Merged

plasticity: fix build#384389
FliegendeWurst merged 3 commits intoNixOS:masterfrom
AmazinAxel:fix-plasticity-build

Conversation

@AmazinAxel
Copy link
Contributor

Plasticity was not building after this commit. This change fixes the build by enabling dontCheckForBrokenSymlinks but this is a band-aid solution. Someone with more time and experience should go through to try fixing the symlinks, but this will fix the build in the meantime. The application works the same as before.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 23, 2025
@nix-owners nix-owners bot requested a review from imadnyc February 23, 2025 01:18
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Feb 23, 2025
@AmazinAxel
Copy link
Contributor Author

I clicked the Sync Fork button on github and it added an additional commit - new to git so I don't know how to revert that
If this is a problem, let me know how to fix it - my apologies!

@Aleksanaa
Copy link
Member

Someone with more time and experience should go through to try fixing the symlinks

So it doesn't have a report on failure? Or you can use tree -a ./result to check for links I guess

@AmazinAxel
Copy link
Contributor Author

So it doesn't have a report on failure? Or you can use tree -a ./result to check for links I guess

It does have an error for each of the broken symlinks but I don't know what to do with that information. We could simply delete those symlinks but I don't know if that's the best course of action. For now to fix the build error, we can just skip the hook. If you think we should delete the symlinks instead I can make a new PR or update this PR
Relevant comment: #370750 (comment)

Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FliegendeWurst FliegendeWurst merged commit 43b3261 into NixOS:master Mar 25, 2025
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants