Skip to content

rustc: add wasm32v1-none target#383875

Merged
alyssais merged 1 commit intoNixOS:stagingfrom
andresilva:andre/rustc-wasm32v1-none
Feb 24, 2025
Merged

rustc: add wasm32v1-none target#383875
alyssais merged 1 commit intoNixOS:stagingfrom
andresilva:andre/rustc-wasm32v1-none

Conversation

@andresilva
Copy link
Copy Markdown
Member

@andresilva andresilva commented Feb 21, 2025 •
edited
Loading

Fixes #383765.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 6.topic: stdenv Standard environment 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: php PHP is a general-purpose scripting language geared towards web development. labels Feb 21, 2025
@andresilva andresilva changed the base branch from master to staging February 21, 2025 09:49
@github-actions github-actions bot removed 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 6.topic: stdenv Standard environment 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: php PHP is a general-purpose scripting language geared towards web development. labels Feb 21, 2025
@andresilva andresilva changed the title Andre/rustc wasm32v1 none rustc: add wasm32v1-none target Feb 21, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Feb 21, 2025
alyssais
alyssais approved these changes Feb 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just working on my own PR where I went through all the targets and checked if there were any that now worked to enable, but we can go ahead with this one first while I finish it :)

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 21, 2025
@andresilva
Copy link
Copy Markdown
Member Author

andresilva commented Feb 21, 2025

I built a master version of the polkadot package which I know will use the wasm32v1-none target if available. It worked successfully.

@alyssais alyssais merged commit b8de2d2 into NixOS:staging Feb 24, 2025
andresilva added a commit to andresilva/polkadot.nix that referenced this pull request Apr 8, 2025
@andresilva
polkadot-sdk: 2412-4 -> 2503
0bfa160 
with paritytech/polkadot-sdk#7008
and NixOS/nixpkgs#383875 we can now
build the runtimes again using a stable rust compiler and no
hacks.

tests are also working.
@andresilva andresilva mentioned this pull request Apr 8, 2025
Merged
13 tasks
andresilva added a commit to andresilva/polkadot.nix that referenced this pull request Apr 8, 2025
@andresilva
polkadot-sdk: 2412-4 -> 2503
24a29dd 
with paritytech/polkadot-sdk#7008
and NixOS/nixpkgs#383875 we can now
build the runtimes again using a stable rust compiler and no
hacks.

tests are also working.
andresilva added a commit to andresilva/nixpkgs that referenced this pull request Apr 8, 2025
@andresilva
polkadot: 2412-4 -> 2503
64e9c19 
with paritytech/polkadot-sdk#7008
and NixOS#383875 we can now
build the runtimes again using a stable rust compiler and no
hacks.

tests are also working again.
andresilva added a commit to andresilva/polkadot.nix that referenced this pull request Apr 8, 2025
@andresilva
polkadot-sdk: 2412-4 -> 2503
97d7cfa 
with paritytech/polkadot-sdk#7008
and NixOS/nixpkgs#383875 we can now
build the runtimes again using a stable rust compiler and no
hacks.

tests are also working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais alyssais approved these changes

@winterqt winterqt Awaiting requested review from winterqt

@Mic92 Mic92 Awaiting requested review from Mic92

@figsoda figsoda Awaiting requested review from figsoda

@zowoq zowoq Awaiting requested review from zowoq

Assignees

No one assigned

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rustc: add wasm32v1-none target

3 participants

@andresilva @alyssais @wegank