Skip to content

bashFHS: bypass by-name check#383280

Closed
kirillrdy wants to merge 1 commit intoNixOS:staging-nextfrom
kirillrdy:staging-next
Closed

bashFHS: bypass by-name check#383280
kirillrdy wants to merge 1 commit intoNixOS:staging-nextfrom
kirillrdy:staging-next

Conversation

@kirillrdy
Copy link
Member

@kirillrdy kirillrdy commented Feb 19, 2025

for staging-next

https://github.com/NixOS/nixpkgs/actions/runs/13408791159/job/37453986837?pr=380680

not sure if that's the best way

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kirillrdy kirillrdy marked this pull request as ready for review February 19, 2025 09:01
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 19, 2025
@infinisil
Copy link
Member

This problem was ignored in the original PR to master, so I think it would also be fine to ignore for staging. Check the logs of the failing CI check to see whether it would break when merged (if it's just this, it shouldn't)

@kirillrdy
Copy link
Member Author

#379368 was merged to staging

Check the logs of the failing CI check to see whether it would break when merged

not sure what to look for, feel free to close this if everything is ok

@kirillrdy kirillrdy deleted the staging-next branch March 20, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants