bashFHS: bypass by-name check#383280
Closed
kirillrdy wants to merge 1 commit intoNixOS:staging-nextfrom
Closed
Conversation
Member
|
This problem was ignored in the original PR to master, so I think it would also be fine to ignore for staging. Check the logs of the failing CI check to see whether it would break when merged (if it's just this, it shouldn't) |
Member
Author
|
#379368 was merged to staging
not sure what to look for, feel free to close this if everything is ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for staging-next
https://github.com/NixOS/nixpkgs/actions/runs/13408791159/job/37453986837?pr=380680
not sure if that's the best way
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.