Skip to content

luaPackages.orgmode: fix tree-sitter-org error#382882

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
khaneliman:orgmode
Feb 17, 2025
Merged

luaPackages.orgmode: fix tree-sitter-org error#382882
GaetanLepage merged 1 commit intoNixOS:masterfrom
khaneliman:orgmode

Conversation

@khaneliman
Copy link
Contributor

Things done

Was called out in #356517 (comment) as an issue with conversion so we didn't do it. But, it was done anyways in #376370.

We observe the error reported earlier in nixvim now: nix-community/nixvim#2991 (comment).

With this change I can get that test to pass.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. label Feb 17, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 17, 2025
Copy link
Contributor

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382882


x86_64-linux

✅ 6 packages built:
  • lua51Packages.orgmode
  • luaPackages.orgmode (lua52Packages.orgmode)
  • lua53Packages.orgmode
  • lua54Packages.orgmode
  • luajitPackages.orgmode
  • vimPlugins.orgmode

aarch64-linux

✅ 6 packages built:
  • lua51Packages.orgmode
  • luaPackages.orgmode (lua52Packages.orgmode)
  • lua53Packages.orgmode
  • lua54Packages.orgmode
  • luajitPackages.orgmode
  • vimPlugins.orgmode

x86_64-darwin

✅ 6 packages built:
  • lua51Packages.orgmode
  • luaPackages.orgmode (lua52Packages.orgmode)
  • lua53Packages.orgmode
  • lua54Packages.orgmode
  • luajitPackages.orgmode
  • vimPlugins.orgmode

aarch64-darwin

✅ 6 packages built:
  • lua51Packages.orgmode
  • luaPackages.orgmode (lua52Packages.orgmode)
  • lua53Packages.orgmode
  • lua54Packages.orgmode
  • luajitPackages.orgmode
  • vimPlugins.orgmode

@GaetanLepage GaetanLepage merged commit 8f5af08 into NixOS:master Feb 17, 2025
25 of 27 checks passed
@khaneliman khaneliman deleted the orgmode branch February 17, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants