Skip to content

python312Packages.s3fs: 2024.12.0 -> 2025.2.0#382057

Merged
NickCao merged 3 commits intoNixOS:masterfrom
GaetanLepage:s3fs
Feb 15, 2025
Merged

python312Packages.s3fs: 2024.12.0 -> 2025.2.0#382057
NickCao merged 3 commits intoNixOS:masterfrom
GaetanLepage:s3fs

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Feb 14, 2025 •
edited
Loading

Things done

Changelog: https://github.com/fsspec/s3fs/raw/2025.2.0/docs/source/changelog.rst

The amount of failing/erroring tests is quite worrying...

= 162 passed, 2 skipped, 162 deselected, 6 xfailed, 4723 warnings in 79.88s (0:01:19) =

cc @teh

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 14, 2025
@nix-owners nix-owners bot requested a review from teh February 14, 2025 14:13
@nix-owners nix-owners bot requested review from NickCao and bcdarwin February 14, 2025 15:14
@NickCao
Copy link
Member

NickCao commented Feb 14, 2025

Polluted by unrelated commits?

@GaetanLepage GaetanLepage force-pushed the s3fs branch 2 times, most recently from f996e8d to a0ad1e5 Compare February 15, 2025 00:07
@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 15, 2025
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Feb 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382057

x86_64-linux

✅ 26 packages built:
  • browsr
  • browsr.dist
  • datatrove
  • datatrove.dist
  • dvc-with-remotes
  • dvc-with-remotes.dist
  • ome_zarr (python312Packages.ome-zarr)
  • ome_zarr.dist (python312Packages.ome-zarr.dist)
  • python312Packages.dvc-s3
  • python312Packages.dvc-s3.dist
  • python312Packages.llama-index-readers-s3
  • python312Packages.llama-index-readers-s3.dist
  • python312Packages.pins
  • python312Packages.pins.dist
  • python312Packages.pyiceberg
  • python312Packages.pyiceberg.dist
  • python312Packages.s3fs
  • python312Packages.s3fs.dist
  • python313Packages.dvc-s3
  • python313Packages.dvc-s3.dist
  • python313Packages.ome-zarr
  • python313Packages.ome-zarr.dist
  • python313Packages.pins
  • python313Packages.pins.dist
  • python313Packages.s3fs
  • python313Packages.s3fs.dist

aarch64-linux

✅ 26 packages built:
  • browsr
  • browsr.dist
  • datatrove
  • datatrove.dist
  • dvc-with-remotes
  • dvc-with-remotes.dist
  • ome_zarr (python312Packages.ome-zarr)
  • ome_zarr.dist (python312Packages.ome-zarr.dist)
  • python312Packages.dvc-s3
  • python312Packages.dvc-s3.dist
  • python312Packages.llama-index-readers-s3
  • python312Packages.llama-index-readers-s3.dist
  • python312Packages.pins
  • python312Packages.pins.dist
  • python312Packages.pyiceberg
  • python312Packages.pyiceberg.dist
  • python312Packages.s3fs
  • python312Packages.s3fs.dist
  • python313Packages.dvc-s3
  • python313Packages.dvc-s3.dist
  • python313Packages.ome-zarr
  • python313Packages.ome-zarr.dist
  • python313Packages.pins
  • python313Packages.pins.dist
  • python313Packages.s3fs
  • python313Packages.s3fs.dist

x86_64-darwin

✅ 26 packages built:
  • browsr
  • browsr.dist
  • datatrove
  • datatrove.dist
  • dvc-with-remotes
  • dvc-with-remotes.dist
  • ome_zarr (python312Packages.ome-zarr)
  • ome_zarr.dist (python312Packages.ome-zarr.dist)
  • python312Packages.dvc-s3
  • python312Packages.dvc-s3.dist
  • python312Packages.llama-index-readers-s3
  • python312Packages.llama-index-readers-s3.dist
  • python312Packages.pins
  • python312Packages.pins.dist
  • python312Packages.pyiceberg
  • python312Packages.pyiceberg.dist
  • python312Packages.s3fs
  • python312Packages.s3fs.dist
  • python313Packages.dvc-s3
  • python313Packages.dvc-s3.dist
  • python313Packages.ome-zarr
  • python313Packages.ome-zarr.dist
  • python313Packages.pins
  • python313Packages.pins.dist
  • python313Packages.s3fs
  • python313Packages.s3fs.dist

aarch64-darwin

✅ 26 packages built:
  • browsr
  • browsr.dist
  • datatrove
  • datatrove.dist
  • dvc-with-remotes
  • dvc-with-remotes.dist
  • ome_zarr (python312Packages.ome-zarr)
  • ome_zarr.dist (python312Packages.ome-zarr.dist)
  • python312Packages.dvc-s3
  • python312Packages.dvc-s3.dist
  • python312Packages.llama-index-readers-s3
  • python312Packages.llama-index-readers-s3.dist
  • python312Packages.pins
  • python312Packages.pins.dist
  • python312Packages.pyiceberg
  • python312Packages.pyiceberg.dist
  • python312Packages.s3fs
  • python312Packages.s3fs.dist
  • python313Packages.dvc-s3
  • python313Packages.dvc-s3.dist
  • python313Packages.ome-zarr
  • python313Packages.ome-zarr.dist
  • python313Packages.pins
  • python313Packages.pins.dist
  • python313Packages.s3fs
  • python313Packages.s3fs.dist

@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Feb 15, 2025
@NickCao NickCao mentioned this pull request Feb 15, 2025
Merged
13 tasks
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Feb 15, 2025

Thanks @NickCao for opening #382202. However, I think that this is still worth being merged as the package is failing on master currently.
It would be a temporary solution while your PR goes through the staging cycle.

NickCao
NickCao approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested basic functionality of s3fs (opening, reading files), seems to work.

@NickCao NickCao merged commit f7bf632 into NixOS:master Feb 15, 2025
74 of 75 checks passed
@GaetanLepage GaetanLepage deleted the s3fs branch February 15, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCao NickCao NickCao approved these changes

@teh teh Awaiting requested review from teh

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GaetanLepage @NickCao