Skip to content

john: fix broken symlinks#381628

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
nmouha:patch-2
Feb 19, 2025
Merged

john: fix broken symlinks#381628
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
nmouha:patch-2

Conversation

@nmouha
Copy link
Contributor

@nmouha nmouha commented Feb 13, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 13, 2025
@brianmcgillion
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381628


x86_64-linux

✅ 5 packages built:
  • adenum
  • john
  • johnny
  • wifite2
  • wifite2.dist

aarch64-linux

✅ 5 packages built:
  • adenum
  • john
  • johnny
  • wifite2
  • wifite2.dist

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaetanLepage
Copy link
Contributor

Please, rename the commit/PR to john: fix broken symlinks.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381628


x86_64-linux

✅ 5 packages built:
  • adenum
  • john
  • johnny
  • wifite2
  • wifite2.dist

aarch64-linux

✅ 5 packages built:
  • adenum
  • john
  • johnny
  • wifite2
  • wifite2.dist

x86_64-darwin

✅ 2 packages built:
  • adenum
  • john

aarch64-darwin

✅ 2 packages built:
  • adenum
  • john

@nmouha nmouha changed the title Build failure: john (broken symlink) john: fix broken symlinks Feb 14, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 14, 2025
@bjornfor
Copy link
Contributor

@nmouha: It seems you changed the PR title, but the git commit message needs updating: Update package.nix -> john: fix broken symlinks

@SuperSandro2000 SuperSandro2000 merged commit 374e00a into NixOS:master Feb 19, 2025
32 checks passed
@SuperSandro2000
Copy link
Member

just squash merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants