bitwarden-cli: 2024.12.0 -> 2025.1.3#381559
Closed
bobvanderlinden wants to merge 3 commits intoNixOS:masterfrom
Closed
bitwarden-cli: 2024.12.0 -> 2025.1.3#381559bobvanderlinden wants to merge 3 commits intoNixOS:masterfrom
bobvanderlinden wants to merge 3 commits intoNixOS:masterfrom
Conversation
esbuild binaries are being downloaded through npm. We can work around this using an environment variable, but since there are 2 different versions of esbuild being used in the lock file, we need to do some juggling of this envvar. Skipping those scripts also works and is less complex.
ofborg
bot
added
the
2.status: merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/bitwarden/clients/releases/tag/cli-v2025.1.3
The bitwarden-cli build was already broken due to dangling symlinks and the check that was recently introduced cross-repo. See #370750
2025.1.3 also introduced another breakage, where it now tries to download esbuild prebuilt binaries. Since there are 2 versions of esbuild it needs. I solved this problem the same way as was done in #381008
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.