[Backport release 24.11] gradle 8.10.2 -> 8.12

[britter]

Manual backport of #356109, after automatic backport failed.

Cherry-picking resulted in a conflict in keyguard/deps.json. I accepted the version from master and then ran the dependency update again based on my backport branch.

[FliegendeWurst]

nixpkgs-review passes on x64 Linux.

LGTM assuming there were no breaking changes in Gradle 8.12. Besides the required deps.json updates.

[britter]

The release notes for 8.12 mention a few potential breaking changes: https://docs.gradle.org/8.12/userguide/upgrading_version_8.html#potential_breaking_changes_2
Is that a problem?

[chayleaf]

Is that a problem?

Depends on whether build failures of downstream packages are within scope of nixpkgs backwards compatibility. If yes, then that is very much a problem (certain packages even break in-tree because of these updates).

[britter]

8.12 release notes don't go into detail how the Kotlin release could break a build. I've reviewed the Kotlin 2.0.0 release notes and funny enough they don't even list what's breaking.

The other change about daemonJvm will definitely break a build using the old API. So I guess that's a show stopper.

[chayleaf]

Kotlin releases can break builds because Gradle package versions may depend on the bundled Kotlin version, a changed Kotlin version may result in a different dependency version, which means the new version won't be cached (I'm thinking of adding warnings if the build-time version doesn't match the lock-time version). However, this is only a problem in no-internet scenarios like Nix sandbox.

[britter]

@chayleaf this all sounds like we should close this, although @FliegendeWurst reported that nixpkgs-review was successful.

[FliegendeWurst]

Actually I just checked again, it seems (at least) ghidra fails to build. Not sure why it did not pick that up previously.

[britter]

Okay, it sounds like we should stick with 8.10.2 on release-24.11, although people will miss quite some Gradle releases until 25.05 is released.