Skip to content

texpresso: fix nextonic symlink#381454

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
MattSturgeon:texpresso-tonic
Feb 12, 2025
Merged

texpresso: fix nextonic symlink#381454
GaetanLepage merged 1 commit intoNixOS:masterfrom
MattSturgeon:texpresso-tonic

Conversation

@MattSturgeon
Copy link
Contributor

@MattSturgeon MattSturgeon commented Feb 12, 2025

Remove the broken nextonic symlink in the texpresso-tonic package. Fixes build failure, due to new symlink checking added in #370750.

We could create a fixed symlink, but TBH I don't think there's any value in the nextonic alias, especially given the texpresso-tonic package can't be directly installed... AFAICT it is only ever available within texpresso's private PATH?

If we did want to keep the alias, we'd just add this to postInstall:

ln -s $out/bin/texpresso-tonic $out/bin/nextonic

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: TeX Issues regarding texlive and TeX in general label Feb 12, 2025
@MattSturgeon MattSturgeon requested a review from NickHu February 12, 2025 13:30
@MattSturgeon
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381454


x86_64-linux

✅ 1 package built:
  • texpresso

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 12, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381454


x86_64-linux

✅ 1 package built:
  • texpresso

aarch64-linux

✅ 1 package built:
  • texpresso

x86_64-darwin

✅ 1 package built:
  • texpresso

aarch64-darwin

✅ 1 package built:
  • texpresso

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GaetanLepage GaetanLepage merged commit 171b478 into NixOS:master Feb 12, 2025
58 of 59 checks passed
@MattSturgeon MattSturgeon deleted the texpresso-tonic branch February 12, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants