Skip to content

write-good: remove node_modules/.bin#381434

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
MattSturgeon:write-good
Feb 12, 2025
Merged

write-good: remove node_modules/.bin#381434
GaetanLepage merged 1 commit intoNixOS:masterfrom
MattSturgeon:write-good

Conversation

@MattSturgeon
Copy link
Contributor

@MattSturgeon MattSturgeon commented Feb 12, 2025

Fixes the build failure caused by symlinks now being checked: #370750.

I don't think lib/node_modules/write-good/node_modules/.bin is used by anything? If it was, there would've already been issues due to the broken symlinks. But maybe there's some better solution or underlying issue I'm missing.

Reported by @pinarruiz downstream in nix-community/nixvim#3003

(No maintainers to ping for this package)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Fixes the build by removing broken symlinks.
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 12, 2025
@MattSturgeon
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381434


x86_64-linux

✅ 1 package built:
  • write-good

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381434


x86_64-linux

✅ 1 package built:
  • write-good

aarch64-linux

✅ 1 package built:
  • write-good

x86_64-darwin

✅ 1 package built:
  • write-good

aarch64-darwin

✅ 1 package built:
  • write-good

@GaetanLepage GaetanLepage merged commit 5e4947a into NixOS:master Feb 12, 2025
50 of 51 checks passed
@MattSturgeon MattSturgeon deleted the write-good branch February 12, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants