mastodon: remove workspace package with broken symlinks#381428
Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom Feb 12, 2025
Merged
mastodon: remove workspace package with broken symlinks#381428GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage merged 1 commit intoNixOS:masterfrom
Conversation
MattSturgeon
requested review from
Izorkin,
erictapen,
ghuntley and
networkException
github-actions
bot
added
10.rebuild-darwin: 0
GaetanLepage
approved these changes
Feb 12, 2025
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #380366 (build failure) caused by broken symlinks now being checked (#370750)
The fix was investigated and proposed by @networkException in #380366 (comment). I'm just upstreaming that solution.
I believe the nixpkgs-review failures are unrelated,
nix-build -A mastodon.mastodonModulesbuilds without issue.cc maintainers: @happy-river @erictapen @Izorkin @ghuntley
nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-reviewx86_64-linux❌ 33 packages failed to build:
✅ 56 packages built:
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.