haskell-pango: patch to make gtk build with newer (>= 1.56) pango#381415
Merged
sternenseemann merged 1 commit intoNixOS:masterfrom Feb 12, 2025
Merged
haskell-pango: patch to make gtk build with newer (>= 1.56) pango#381415sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann merged 1 commit intoNixOS:masterfrom
Conversation
Member
|
The canonical commit message prefix is Does this change mean, that currently haskellPackages.pango is broken on master? |
Contributor
Author
|
technically it's the gtk build that breaks, will make that clearer |
bb39ccf to
aa0881a
Compare
Member
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream issue+pr: gtk2hs/gtk2hs#337, gtk2hs/gtk2hs#336
Things done
Successfully built
haskellPackages.gtkfrom this branch.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.