Skip to content

haskell-pango: patch to make gtk build with newer (>= 1.56) pango#381415

Merged
sternenseemann merged 1 commit intoNixOS:masterfrom
xaverdh:haskell-pango-wrap-none
Feb 12, 2025
Merged

haskell-pango: patch to make gtk build with newer (>= 1.56) pango#381415
sternenseemann merged 1 commit intoNixOS:masterfrom
xaverdh:haskell-pango-wrap-none

Conversation

@xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Feb 12, 2025

Upstream issue+pr: gtk2hs/gtk2hs#337, gtk2hs/gtk2hs#336

Things done

Successfully built haskellPackages.gtk from this branch.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Feb 12, 2025
@maralorn
Copy link
Member

The canonical commit message prefix is haskellPackages.pango.

Does this change mean, that currently haskellPackages.pango is broken on master?

@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 12, 2025
@xaverdh
Copy link
Contributor Author

xaverdh commented Feb 12, 2025

technically it's the gtk build that breaks, will make that clearer

@xaverdh xaverdh force-pushed the haskell-pango-wrap-none branch from bb39ccf to aa0881a Compare February 12, 2025 09:58
@xaverdh xaverdh changed the title haskell-pango: patch to build with newer (>= 1.56) pango haskell-pango: patch to make gtk build with newer (>= 1.56) pango Feb 12, 2025
@sternenseemann sternenseemann merged commit ca42117 into NixOS:master Feb 12, 2025
42 of 43 checks passed
@xaverdh xaverdh deleted the haskell-pango-wrap-none branch February 12, 2025 11:58
@sternenseemann
Copy link
Member

cc @wolfgangwalther

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants