Skip to content

[Backport release-24.11] electron{-source,-bin,chromedriver}: init at 34.0.2, 33.3.2 -> 33.4.0, 34.0.2 -> 34.1.1#381180

Merged
emilylange merged 7 commits intoNixOS:release-24.11from
emilylange:backport-380954-to-release-24.11
Feb 11, 2025
Merged

[Backport release-24.11] electron{-source,-bin,chromedriver}: init at 34.0.2, 33.3.2 -> 33.4.0, 34.0.2 -> 34.1.1#381180
emilylange merged 7 commits intoNixOS:release-24.11from
emilylange:backport-380954-to-release-24.11

Conversation

@emilylange
Copy link
Member

@emilylange emilylange commented Feb 11, 2025

Partial backport of #376770 without the breaking electron: 33 -> 34 change and all of #380954.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

ImUrX and others added 7 commits February 11, 2025 15:38
@ImUrX @emilylange
electron_34-bin: init at 34.0.2
205ce82 
(cherry picked from commit af1676b)
@ImUrX @emilylange
electron-chromedriver_34: init at 34.0.2
d3247e0 
(cherry picked from commit 920061a)
@emilylange
electron_33-bin: 33.3.2 -> 33.4.0
614dcaf 
- Changelog: https://github.com/electron/electron/releases/tag/v33.4.0
- Diff: electron/electron@refs/tags/v33.3.2...v33.4.0

(cherry picked from commit d7b808e)
@emilylange
electron-source.electron_33: 33.3.2 -> 33.4.0
ddae436 
- Changelog: https://github.com/electron/electron/releases/tag/v33.4.0
- Diff: electron/electron@refs/tags/v33.3.2...v33.4.0

(cherry picked from commit 5d383f6)
@emilylange
electron-chromedriver_33: 33.3.2 -> 33.4.0
ae1a47b 
- Changelog: https://github.com/electron/electron/releases/tag/v33.4.0
- Diff: electron/electron@refs/tags/v33.3.2...v33.4.0

(cherry picked from commit cd2b7bd)
@emilylange
electron_34-bin: 34.0.2 -> 34.1.1
cf50757 
- Changelog: https://github.com/electron/electron/releases/tag/v34.1.1
- Changelog: https://github.com/electron/electron/releases/tag/v34.1.0
- Diff: electron/electron@refs/tags/v34.0.2...v34.1.1

(cherry picked from commit 48d1277)
@emilylange
electron-chromedriver_34: 34.0.2 -> 34.1.1
8a5b2d1 
- Changelog: https://github.com/electron/electron/releases/tag/v34.1.1
- Changelog: https://github.com/electron/electron/releases/tag/v34.1.0
- Diff: electron/electron@refs/tags/v34.0.2...v34.1.1

(cherry picked from commit 66787fd)
@emilylange emilylange added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Feb 11, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 11, 2025
@emilylange
Copy link
Member Author

emilylange commented Feb 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381180

x86_64-linux

✅ 75 packages built:
  • affine
  • antares
  • antimatter-dimensions
  • appium-inspector
  • bilibili
  • bitwarden-desktop
  • bitwarden-directory-connector
  • blockbench
  • bruno
  • camunda-modeler
  • caprine
  • chatd
  • drawio
  • drawio-headless
  • electron (electron_33)
  • electron-bin (electron_33-bin)
  • electron-chromedriver (electron-chromedriver_33)
  • electron-chromedriver_34
  • electron_34 (electron_34-bin)
  • element-desktop
  • equibop
  • fcast-receiver
  • feishin
  • follow
  • freetube
  • gfn-electron
  • goofcord
  • headset
  • httptoolkit
  • itch
  • jitsi-meet-electron
  • kando
  • koodo-reader
  • kuro
  • mattermost-desktop
  • mqtt-explorer
  • nix-tour
  • obsidian
  • open-stage-control
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • podman-desktop
  • pritunl-client
  • proton-pass
  • protonmail-desktop
  • python311Packages.mkdocs-drawio-exporter
  • python311Packages.mkdocs-drawio-exporter.dist
  • python312Packages.mkdocs-drawio-exporter
  • python312Packages.mkdocs-drawio-exporter.dist
  • r2modman
  • redisinsight
  • revolt-desktop
  • ride
  • sharedown
  • sieve-editor-gui
  • siyuan
  • standardnotes
  • stretchly
  • super-productivity
  • terra-station
  • tetrio-desktop
  • thedesk
  • threema-desktop
  • uhk-agent
  • uhk-udev-rules
  • uivonim
  • vesktop
  • vieb
  • webcord
  • webcord-vencord
  • webtorrent_desktop
  • yandex-music
  • youtube-music
  • ytdownloader
  • ytmdesktop

@emilylange emilylange merged commit c708711 into NixOS:release-24.11 Feb 11, 2025
27 of 28 checks passed
@emilylange emilylange deleted the backport-380954-to-release-24.11 branch February 11, 2025 19:40
@emilylange emilylange changed the title electron{-source,-bin,chromedriver}: init at 34.0.2, 33.3.2 -> 33.4.0, 34.0.2 -> 34.1.1 [Backport release-24.11] electron{-source,-bin,chromedriver}: init at 34.0.2, 33.3.2 -> 33.4.0, 34.0.2 -> 34.1.1 Feb 11, 2025
@teutat3s
Copy link
Member

teutat3s commented Feb 12, 2025

Thank you for taking care of this! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emilylange @teutat3s @ImUrX