haskellPackages: clean up overrides (part 1)#381006
Merged
sternenseemann merged 28 commits intoNixOS:haskell-updatesfrom Feb 11, 2025
Merged
haskellPackages: clean up overrides (part 1)#381006sternenseemann merged 28 commits intoNixOS:haskell-updatesfrom
sternenseemann merged 28 commits intoNixOS:haskell-updatesfrom
Conversation
Builds fine by now without.
Builds fine without it by now.
We have LTS 23 now.
We have LTS 23 now.
Seems to build fine.
Upstream issue is resolved, builds fine.
We have alex 3.5 by now.
Upstream issue is resolved.
Too strict bounds on bytestring.
Passes without it.
This can probably be removed by now, but can't confirm due to failing build of gtk on staging.
Works without.
Not needed anymore.
Pointless to keep it, since the github repo has been deleted, there is no maintainer and this has not been updated in more than 8 years - and of course it's broken anyway.
github-actions
bot
added
the
6.topic: haskell
wolfgangwalther
commented
Feb 10, 2025
wolfgangwalther
force-pushed
the
haskell-cleanup
branch
from
3498feb to
f5d50c1
Compare
github-actions
bot
added
the
10.rebuild-darwin: 2501-5000
github-actions
bot
added
10.rebuild-darwin: 501+
Member
sternenseemann
left a comment
sternenseemann
left a comment
There was a problem hiding this comment.
Thanks, this looks great!
sternenseemann
approved these changes
Feb 10, 2025
Our hspec is at 2.11.10 now and the upstream issue is closed.
Works by now.
sternenseemann
force-pushed
the
haskell-cleanup
branch
from
f5d50c1 to
5244705
Compare
github-actions
bot
added
10.rebuild-linux: 5001+
This was referenced Feb 11, 2025
Member
|
Also here I'm curious how you went about this. Did you go by linked issues primarily? |
Contributor
Author
|
For this, I just went down the file. I looked for two things:
If any of that was present, I tried to build the package with the configuration removed. If it did build or give me a bounds failure different to the one commented, I made a respective change. So.. manual labor, here. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going through
configuration-common.nix, checking issues, testing builds.Let me know whether I should split things up more or less or what suits you best for reviewing.
Things done
I only tested on
haskellPackages, default compiler.Add a 👍 reaction to pull requests you find important.