jefferson: relax cstruct dependency#380735
Conversation
|
|
Looks good to me. I successfully tested basic functionality of jefferson and unblob by extracting an example image. The diffoscope build failure seems to be related to changed import paths between androguard v3.4.0a1 and v4.1.2. Androguard was also recently updated in 47c6362 / #375144 (same PR you mentioned above) |
al3xtjames
left a comment
There was a problem hiding this comment.
LGTM! BTW, I reported this upstream: onekey-sec/jefferson#20
Merged but no new release yet, so I guess we should continue working with the relaxed dependency. Mentioned diffoscope update pr above fixes diffoscope, which is currently broken on master, depends on this change. How to proceed with this? Can we simply merge this pr, because the marked as broken packages are broken anyway right now? |
yep |
fix python import check, by relaxing cstruct dependency.
I've got the following error, when trying to build binwalk:
broken by: 311264f / #375144
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)@tnias @vlaci
Add a 👍 reaction to pull requests you find important.