Skip to content

teleport_17: init at 17.2.1; teleport: Use fetchCargoVendor#380613

Merged
tomberek merged 2 commits intoNixOS:masterfrom
JuliusFreudenberger:teleport_17
Feb 11, 2025
Merged

teleport_17: init at 17.2.1; teleport: Use fetchCargoVendor#380613
tomberek merged 2 commits intoNixOS:masterfrom
JuliusFreudenberger:teleport_17

Conversation

@JuliusFreudenberger
Copy link
Contributor

Add teleport_17 at version 17.2.1

I also switched to useFetchCargoVendor and got rid of the Cargo.lock files as suggested in #376749 (comment).

Teleport 17 requires Go 1.23 to build, so I refactored a bit to be able to set buildGoModule for specific teleport versions.

I intend to change the default teleport to teleport_17 and adding a line in the release notes in another PR, so this one can be backported.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 9, 2025
@JuliusFreudenberger
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380613


x86_64-linux

✅ 6 packages built:
  • teleport (teleport_16)
  • teleport.client (teleport_16.client)
  • teleport_15
  • teleport_15.client
  • teleport_17
  • teleport_17.client

@techknowlogick
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380613


aarch64-darwin

✅ 6 packages built:
  • teleport (teleport_16)
  • teleport.client (teleport_16.client)
  • teleport_15
  • teleport_15.client
  • teleport_17
  • teleport_17.client

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Feb 10, 2025
@JuliusFreudenberger
Copy link
Contributor Author

I forgot to add teleport_17 to the nixos tests.

Copy link
Member

@justinas justinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, looks good! And I'm happy we can get rid of vendored Cargo.lock files.

@JuliusFreudenberger
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380613


x86_64-linux

✅ 6 packages built:
  • teleport (teleport_16)
  • teleport.client (teleport_16.client)
  • teleport_15
  • teleport_15.client
  • teleport_17
  • teleport_17.client

1 similar comment
@tomberek
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380613


x86_64-linux

✅ 6 packages built:
  • teleport (teleport_16)
  • teleport.client (teleport_16.client)
  • teleport_15
  • teleport_15.client
  • teleport_17
  • teleport_17.client

@tomberek tomberek merged commit ad4373c into NixOS:master Feb 11, 2025
27 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 12, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-380613-to-release-24.11 origin/release-24.11
cd .worktree/backport-380613-to-release-24.11
git switch --create backport-380613-to-release-24.11
git cherry-pick -x ce9995c88d940119e6685c97ac90f7d72996809f 86f814fc41eb5ab804b6f2414a84c642e5cb901a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants