teleport_17: init at 17.2.1; teleport: Use fetchCargoVendor#380613
Merged
tomberek merged 2 commits intoNixOS:masterfrom Feb 11, 2025
Merged
teleport_17: init at 17.2.1; teleport: Use fetchCargoVendor#380613tomberek merged 2 commits intoNixOS:masterfrom
tomberek merged 2 commits intoNixOS:masterfrom
Conversation
Contributor
Author
|
Member
|
techknowlogick
approved these changes
Feb 10, 2025
7b02093 to
87a698e
Compare
Contributor
Author
|
I forgot to add teleport_17 to the nixos tests. |
justinas
approved these changes
Feb 10, 2025
Member
justinas
left a comment
There was a problem hiding this comment.
Thanks for doing this, looks good! And I'm happy we can get rid of vendored Cargo.lock files.
87a698e to
86f814f
Compare
Contributor
Author
|
1 similar comment
Contributor
|
tomberek
approved these changes
Feb 11, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-380613-to-release-24.11 origin/release-24.11
cd .worktree/backport-380613-to-release-24.11
git switch --create backport-380613-to-release-24.11
git cherry-pick -x ce9995c88d940119e6685c97ac90f7d72996809f 86f814fc41eb5ab804b6f2414a84c642e5cb901a |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add teleport_17 at version 17.2.1
I also switched to
useFetchCargoVendorand got rid of theCargo.lockfiles as suggested in #376749 (comment).Teleport 17 requires Go 1.23 to build, so I refactored a bit to be able to set
buildGoModulefor specific teleport versions.I intend to change the default
teleporttoteleport_17and adding a line in the release notes in another PR, so this one can be backported.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.