Skip to content

haskellPackages.postgrest: 12.0.3 -> 12.2.7; fix static build#380422

Closed
wolfgangwalther wants to merge 7 commits intoNixOS:haskell-updatesfrom
wolfgangwalther:haskell-update-postgrest
Closed

haskellPackages.postgrest: 12.0.3 -> 12.2.7; fix static build#380422
wolfgangwalther wants to merge 7 commits intoNixOS:haskell-updatesfrom
wolfgangwalther:haskell-update-postgrest

Conversation

@wolfgangwalther
Copy link
Contributor

As discussed in #371032 (comment).

I left a fixup! upstream bumps in there, because almost all of them already have a new release. This could be dropped in case a fresh pull from hackage is anywhere near (minus the configurator-pg, but I'm working on getting that released).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Feb 8, 2025
@wolfgangwalther wolfgangwalther changed the title haskellPackages.postgrest: update to latest; fix static build haskellPackages.postgrest: 12.0.3 -> 12.2.7; fix static build Feb 8, 2025
@nix-owners nix-owners bot requested a review from maralorn February 8, 2025 18:32
@sternenseemann
Copy link
Member

I think we need a Hackage bump again for a number of things. I'm happy to do it when it suits you, i.e. let me know when is a good time w.r.t. configurator-pg.

@sternenseemann
Copy link
Member

Obviously, we should deal with the !fixup commit one way or the other before merging.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 9, 2025
@wolfgangwalther
Copy link
Contributor Author

I think we need a Hackage bump again for a number of things. I'm happy to do it when it suits you, i.e. let me know when is a good time w.r.t. configurator-pg.

There is a new revision for configurator-pg on hackage: https://hackage.haskell.org/package/configurator-pg-0.2.10/revisions/

So we should be good to go from here.

We recently introduced a libpq package to reduce the number of
dependencies for the server packages. Thus use that more lightweight
libpq package.
Fixes building with Stackage 23 as well.
PostgREST depends on the pkgsStatic build downstream, let's make sure
the basics don't break here.
@wolfgangwalther wolfgangwalther force-pushed the haskell-update-postgrest branch from 55e2d1b to 6ff2be5 Compare February 10, 2025 13:34
@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Feb 10, 2025
@sternenseemann
Copy link
Member

Since I've accidentally created a merge conflict, I've manually cherry-picked all commits here onto haskell-updates.

I've also modified f8544ff to use the self fix point for resolving the versioned attribute. That way, potential overrides to the versioned attribute in the same overlay won't be ignored (i.e. it's best practice to use self for overrides that are essentially aliasing/renaming).

@wolfgangwalther wolfgangwalther deleted the haskell-update-postgrest branch February 10, 2025 14:42
@wolfgangwalther
Copy link
Contributor Author

I've also modified f8544ff to use the self fix point for resolving the versioned attribute. That way, potential overrides to the versioned attribute in the same overlay won't be ignored (i.e. it's best practice to use self for overrides that are essentially aliasing/renaming).

Ah, makes sense, thanks!

@sternenseemann
Copy link
Member

https://hydra.nixos.org/build/288779527 🎉

@wolfgangwalther
Copy link
Contributor Author

Love it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants