Skip to content

Revert "python3Packages.mitmproxy: 11.0.2 -> 11.1.0" #379960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

Revert "python3Packages.mitmproxy: 11.0.2 -> 11.1.0" #379960

merged 1 commit into from
Feb 7, 2025

Conversation

@MisileLab
Copy link
Contributor

downgrade mitmproxy, because 11.1.0 requires mitmproxy-linux (related pr: #373425)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 7, 2025
@nix-owners nix-owners bot requested a review from SuperSandro2000 February 7, 2025 00:30
@MisileLab MisileLab marked this pull request as draft February 7, 2025 10:45
@MisileLab
Copy link
Contributor Author

I don't have time to fix dependencies, can anyone pickup this pr?

@SuperSandro2000 SuperSandro2000 changed the title mitmproxy: 11.1.0 -> 11.0.2 Revert "python3Packages.mitmproxy: 11.0.2 -> 11.1.0" Feb 7, 2025
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review February 7, 2025 12:59
@SuperSandro2000 SuperSandro2000 merged commit 20ba0c0 into NixOS:master Feb 7, 2025
47 checks passed
@MisileLab MisileLab deleted the mitmproxy-revert branch February 7, 2025 18:09
@MisileLab
Copy link
Contributor Author

@SuperSandro2000
now mitmproxy failed with other error

- pyparsing<=3.2.0,>=2.4.2 not satisfied by version 3.2.1
- ruamel-yaml<=0.18.6,>=0.16 not satisfied by version 0.18.10

@SuperSandro2000
Copy link
Member

We can probably just relax the dependency constraints

@SuperSandro2000
Copy link
Member

#380668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MisileLab @SuperSandro2000