neovim: dont wrap rtp when wrapRc=false#379953
Closed
teto wants to merge 2 commits intoNixOS:masterfrom
Closed
Conversation
In home-manager we dont want to add "--set packpatk/rtp" otherwise packages are loaded twice see: nix-community/home-manager#5964 Since the wrapper args are easily added by the user (by using `finalAttrs.packpathDirs`), I propose we dont set them when wrapRc is set as well.
github-actions
bot
added
6.topic: vim
wegank
added
the
2.status: merge conflict
nixpkgs-ci
bot
added
the
2.status: stale
Member
Author
|
got a better solution at #474920 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In home-manager we dont want to add "--set packpatk/rtp" otherwise packages are loaded twice see:
nix-community/home-manager#5964
Since the wrapper args are easily added by the user (by using
finalAttrs.packpathDirs), I propose we dont set them when wrapRc is set as well.It's a breaking change for anyone using wrapRc.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.