haskell.compiler: unify logic determining whether NCG is available #379365
haskell.compiler: unify logic determining whether NCG is available #379365K900 merged 2 commits intoNixOS:stagingfrom
Conversation
53bf17b to
37ee574
Compare
|
Is a set rebuild for aarch64, see #379039 (comment) |
37ee574 to
3c9eb8b
Compare
This change only consolidates the logic for the source built GHCs which have used the same logic (at least as long as you'd only use the respective supported version ranges of the expressions as inputs).
3c9eb8b to
3f504d0
Compare
See bc6ffb6 for context.
3f504d0 to
d0d7d52
Compare
|
Do we no longer want the darwin bit in |
|
I assume there are more of these re-usable bits. Do we want a file for each or something like |
Exactly, this was an incorrect assumption originally: 59ee081. |
Possibly yes, but I wouldn't want to commit to a design right now. There are multiple approaches we could take for further unifying these expressions. This one could also turn out to be special in a way, since it is one of the few things shared between the source built and binary GHCs. |
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.