.github/labeler-no-sync: fix backport labelling#378567
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Feb 1, 2025
Merged
.github/labeler-no-sync: fix backport labelling#378567wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: haskell
Contributor
Author
|
The codeowners check job must fail here, because it's still looking in |
wolfgangwalther
force-pushed
the
ci-backport-labeler
branch
from
83d098f to
935c290
Compare
github-actions
bot
added
10.rebuild-darwin: 0
Matching on !ci/OWNERS was a mistake, because it's matching *every* PR with a change to a non-OWNERS file. This is not fixable with negation rules in the labeler, but we can take advantage of the fact that OWNERS doesn't have a "." in its name. Also, we used the wrong label...
wolfgangwalther
force-pushed
the
ci-backport-labeler
branch
from
935c290 to
9c33953
Compare
github-actions
bot
added
backport: release-24.11
and removed
6.topic: haskell
FliegendeWurst
approved these changes
Feb 1, 2025
Contributor
Author
|
@infinisil I can't exactly tell from the discussion in #347610, whether |
Member
|
Nah I think it was just for cosmetic reasons (why hide OWNERS in a dotfile?), so this seems fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broken in #374921 (comment) - and results in labelling every incoming PR.
Moving the OWNERS file away seems to be the only way to get the desired behavior. GitHub should only react to
CODEOWNERS, so we should be safe by putting it into.github/OWNERS, right?Things done
Add a 👍 reaction to pull requests you find important.