Skip to content

mattermost-desktop: pin Electron to version 33#378205

Merged
emilylange merged 1 commit intoNixOS:masterfrom
liff:mattermost-desktop/electron_33
Jan 31, 2025
Merged

mattermost-desktop: pin Electron to version 33#378205
emilylange merged 1 commit intoNixOS:masterfrom
liff:mattermost-desktop/electron_33

Conversation

@liff
Copy link
Contributor

@liff liff commented Jan 31, 2025

As requested on #376770.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@liff liff requested a review from emilylange January 31, 2025 06:15
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 31, 2025
Copy link
Member

@teutat3s teutat3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linux aarch64 build looks broken on master since 2025-01-13.

@emilylange emilylange merged commit 0cb96f8 into NixOS:master Jan 31, 2025
25 of 27 checks passed
@liff liff deleted the mattermost-desktop/electron_33 branch July 15, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants