podman-desktop: pin to electron_33#378178
Merged
emilylange merged 1 commit intoNixOS:masterfrom Jan 31, 2025
Merged
Conversation
There are plans [1] to bump electron to _34 by default, and the current 1.13.1 version requires version 33. [1] NixOS#376770 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
13 tasks
teutat3s
approved these changes
Jan 31, 2025
Member
|
Thanks for reacting that fast and thank you even more so for taking the time to explain in the commit message why this is done as per our contributing guidelines :) Note that this is technically breaking the tl;dr: thanks :) |
Contributor
Author
|
@emilylange Thanks for expanded answer. I am new to Nix and appreciate these comments since I can learn the ropes then. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are plans [1] to bump electron to _34 by default, and the current
1.13.1 version requires version 33.
[1] #376770
Signed-off-by: Ihar Hrachyshka ihar.hrachyshka@gmail.com
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.