Skip to content

podman-desktop: pin to electron_33#378178

Merged
emilylange merged 1 commit intoNixOS:masterfrom
booxter:pin-electron-for-podman-desktop
Jan 31, 2025
Merged

podman-desktop: pin to electron_33#378178
emilylange merged 1 commit intoNixOS:masterfrom
booxter:pin-electron-for-podman-desktop

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented Jan 31, 2025

There are plans [1] to bump electron to _34 by default, and the current
1.13.1 version requires version 33.

[1] #376770

Signed-off-by: Ihar Hrachyshka ihar.hrachyshka@gmail.com

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

There are plans [1] to bump electron to _34 by default, and the current
1.13.1 version requires version 33.

[1] NixOS#376770

Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 31, 2025
@emilylange
Copy link
Member

Thanks for reacting that fast and thank you even more so for taking the time to explain in the commit message why this is done as per our contributing guidelines :)

Note that this is technically breaking the .override pattern in nixpkgs, as version pins should usually happen in the callPackage invocation in pkgs/top-level/all-packages.nix and not in the derivation itself.
But this is fine for now and can be deferred to a treewide change when needed, especially given this violation is extremely common among electron dependants in nixpkgs.

tl;dr: thanks :)

@emilylange emilylange merged commit f8e6ae8 into NixOS:master Jan 31, 2025
25 of 27 checks passed
@booxter
Copy link
Contributor Author

booxter commented Jan 31, 2025

@emilylange Thanks for expanded answer. I am new to Nix and appreciate these comments since I can learn the ropes then. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants