neovimRequireCheckHook: improve error message#377507
Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom Feb 5, 2025
Merged
neovimRequireCheckHook: improve error message#377507GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage merged 1 commit intoNixOS:masterfrom
Conversation
nix-owners
bot
requested review from
PerchunPak,
figsoda,
khaneliman,
manveru,
mrcjkb and
rvolosatovs
GaetanLepage
force-pushed
the
neovim-check
branch
from
64a5a4e to
0338bf8
Compare
github-actions
bot
added
10.rebuild-darwin: 1001-2500
Contributor
|
Not really a fan of duplicating the neovim docs in every plugin failure. Would make more sense to just point people to them if they need help. |
13 tasks
Member
Automatic "look here for help" would be better than manual, less friction means more contributions |
Contributor
Author
|
You recommend sticking to: ? |
Contributor
yeah, I didn’t mean manually tell people. I meant direct to the existing documentation instead of duplicating it in console output |
GaetanLepage
force-pushed
the
neovim-check
branch
from
0338bf8 to
2aa9b30
Compare
PerchunPak
approved these changes
Jan 28, 2025
Member
PerchunPak
left a comment
PerchunPak
left a comment
There was a problem hiding this comment.
Though this should wait for #377508
wegank
added
12.approvals: 1
GaetanLepage
force-pushed
the
neovim-check
branch
from
2aa9b30 to
d2e2d6c
Compare
github-actions
bot
added
6.topic: python
github-actions
bot
added
6.topic: vscode
github-actions
bot
removed
6.topic: python
ofborg
bot
added
2.status: merge conflict
github-actions
bot
added
10.rebuild-darwin: 101-500
Contributor
Author
|
Rebased on |
Member
|
|
Member
|
khaneliman
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
The addition of
neovimRequireCheckHookin #352277 was motivated by making the packaging of neovim plugins in nixpkgs more robust.We (nixpkgs neovim maintainers) are fine with, and used to, carefully tweaking the
dependenciesandnvimSkipModulefor each plugin.However, downstream users of
buildVimPluginmight not be familiar with this mechanism.-> I propose to enhance the error message to give more practical information to our users.
Of course, I am open to feedback regarding the wording.
Original author: cc @khaneliman
Motivated by feedback from @ALT-F4-LLC
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.