Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman-bootc: init at 0.1.2 #376469

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evan-goode
Copy link
Member

podman-bootc offers an ergonomic "edit-compile-debug" cycle for bootable containers. The core command is:

podman-bootc run <imagename>

This command creates a new virtual machine, backed by a persistent disk image from a "self install" of the container image, and makes a SSH connection to it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM :)

pkgs/by-name/po/podman-bootc/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/po/podman-bootc/package.nix Show resolved Hide resolved
pkgs/by-name/po/podman-bootc/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/po/podman-bootc/package.nix Show resolved Hide resolved
@evan-goode evan-goode force-pushed the evan-goode/podman-bootc branch from 8920b96 to fa302a5 Compare January 24, 2025 21:34
@evan-goode
Copy link
Member Author

Thanks for the suggestions!

@evan-goode evan-goode requested a review from getchoo January 24, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants