Skip to content

buildPythonPackage: preserve the disabled effect after <pkg>.overrideAttrs #376419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mweinelt merged 1 commit into from
May 23, 2025
Merged

buildPythonPackage: preserve the disabled effect after <pkg>.overrideAttrs #376419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions pkgs/development/interpreters/python/mk-python-derivation.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,11 +452,21 @@ let
# This derivation transformation function must be independent to `attrs`
# for fixed-point arguments support in the future.
transformDrv =
drv:
extendDerivation (
drv.disabled
-> throw "${removePrefix namePrefix drv.name} not supported for interpreter ${python.executable}"
) { } (toPythonModule drv);
let
# Workaround to make the `lib.extendDerivation`-based disabled functionality
# respect `<pkg>.overrideAttrs`
# It doesn't cover `<pkg>.<output>.overrideAttrs`.
disablePythonPackage =
drv:
extendDerivation (
drv.disabled
-> throw "${removePrefix namePrefix drv.name} not supported for interpreter ${python.executable}"
) { } drv
// {
overrideAttrs = fdrv: disablePythonPackage (drv.overrideAttrs fdrv);
};
in
drv: disablePythonPackage (toPythonModule drv);

in
transformDrv self