Skip to content

qbittorrent-cli: init at v1.8.24285.1 #376403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

qbittorrent-cli: init at v1.8.24285.1 #376403

merged 1 commit into from
Jan 30, 2025

Conversation

@pta2002
Copy link
Contributor

@pta2002 pta2002 commented Jan 24, 2025 •
edited
Loading

Added qbittorrent-cli: https://github.com/fedarovich/qbittorrent-cli

Useful tool to control qbittorrent instances via the CLI.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 24, 2025
@pta2002 pta2002 added the 8.has: package (new) This PR adds a new package label Jan 24, 2025
pta2002
pta2002 commented Jan 26, 2025
View reviewed changes
pkgs/by-name/qb/qbittorrent-cli/package.nix Outdated
selfContainedBuild = true;

projectFile = "src/QBittorrent.CommandLineInterface/QBittorrent.CommandLineInterface.csproj";
executables = "qbt";
Copy link
Contributor Author

@pta2002 pta2002 Jan 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@pta2002 pta2002 requested a review from a user January 26, 2025 02:37
GaetanLepage
GaetanLepage reviewed Jan 30, 2025
View reviewed changes
GaetanLepage
GaetanLepage reviewed Jan 30, 2025
View reviewed changes
@GaetanLepage
Copy link
Contributor

GaetanLepage commented Jan 30, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376403

x86_64-linux

✅ 1 package built:
  • qbittorrent-cli

aarch64-linux

✅ 1 package built:
  • qbittorrent-cli

x86_64-darwin

✅ 1 package built:
  • qbittorrent-cli

aarch64-darwin

❌ 1 package failed to build:
  • qbittorrent-cli

@GaetanLepage
Copy link
Contributor

GaetanLepage commented Jan 30, 2025

Fails on aarch64-darwin with

Running phase: configurePhase
Executing dotnetConfigureHook
  Determining projects to restore...
/nix/store/x5dlj03vbd86yrwm2l1n4xlxm62z8rs5-dotnet-sdk-8.0.405/share/dotnet/sdk/8.0.405/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.EolTargetFrameworks.targets(32,5): warning NETSDK1138: The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy. [/private/tmp/nix-build-qbittorrent-cli-1.8.24285.1.drv-0/source/src/QBittorrent.CommandLineInterface/QBittorrent.CommandLineInterface.csproj::TargetFramework=netcoreapp3.1]
/nix/store/x5dlj03vbd86yrwm2l1n4xlxm62z8rs5-dotnet-sdk-8.0.405/share/dotnet/sdk/8.0.405/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(154,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'osx-arm64'. [/private/tmp/nix-build-qbittorrent-cli-1.8.24285.1.drv-0/source/src/QBittorrent.CommandLineInterface/QBittorrent.CommandLineInterface.csproj::TargetFramework=netcoreapp3.1]
/nix/store/x5dlj03vbd86yrwm2l1n4xlxm62z8rs5-dotnet-sdk-8.0.405/share/dotnet/sdk/8.0.405/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(154,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'osx-arm64'. [/private/tmp/nix-build-qbittorrent-cli-1.8.24285.1.drv-0/source/src/QBittorrent.CommandLineInterface/QBittorrent.CommandLineInterface.csproj::TargetFramework=netcoreapp3.1]
/nix/store/x5dlj03vbd86yrwm2l1n4xlxm62z8rs5-dotnet-sdk-8.0.405/share/dotnet/sdk/8.0.405/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(154,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'osx-arm64'. [/private/tmp/nix-build-qbittorrent-cli-1.8.24285.1.drv-0/source/src/QBittorrent.CommandLineInterface/QBittorrent.CommandLineInterface.csproj::TargetFramework=netcoreapp3.1]
/nix/store/x5dlj03vbd86yrwm2l1n4xlxm62z8rs5-dotnet-sdk-8.0.405/share/dotnet/sdk/8.0.405/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(154,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'osx-arm64'. [/private/tmp/nix-build-qbittorrent-cli-1.8.24285.1.drv-0/source/src/QBittorrent.CommandLineInterface/QBittorrent.CommandLineInterface.csproj::TargetFramework=netcoreapp3.1]

@pta2002
Copy link
Contributor Author

pta2002 commented Jan 30, 2025

Fails on aarch64-darwin with

Running phase: configurePhase
Executing dotnetConfigureHook
  Determining projects to restore...
/nix/store/x5dlj03vbd86yrwm2l1n4xlxm62z8rs5-dotnet-sdk-8.0.405/share/dotnet/sdk/8.0.405/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.EolTargetFrameworks.targets(32,5): warning NETSDK1138: The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy. [/private/tmp/nix-build-qbittorrent-cli-1.8.24285.1.drv-0/source/src/QBittorrent.CommandLineInterface/QBittorrent.CommandLineInterface.csproj::TargetFramework=netcoreapp3.1]
/nix/store/x5dlj03vbd86yrwm2l1n4xlxm62z8rs5-dotnet-sdk-8.0.405/share/dotnet/sdk/8.0.405/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(154,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'osx-arm64'. [/private/tmp/nix-build-qbittorrent-cli-1.8.24285.1.drv-0/source/src/QBittorrent.CommandLineInterface/QBittorrent.CommandLineInterface.csproj::TargetFramework=netcoreapp3.1]
/nix/store/x5dlj03vbd86yrwm2l1n4xlxm62z8rs5-dotnet-sdk-8.0.405/share/dotnet/sdk/8.0.405/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(154,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'osx-arm64'. [/private/tmp/nix-build-qbittorrent-cli-1.8.24285.1.drv-0/source/src/QBittorrent.CommandLineInterface/QBittorrent.CommandLineInterface.csproj::TargetFramework=netcoreapp3.1]
/nix/store/x5dlj03vbd86yrwm2l1n4xlxm62z8rs5-dotnet-sdk-8.0.405/share/dotnet/sdk/8.0.405/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(154,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'osx-arm64'. [/private/tmp/nix-build-qbittorrent-cli-1.8.24285.1.drv-0/source/src/QBittorrent.CommandLineInterface/QBittorrent.CommandLineInterface.csproj::TargetFramework=netcoreapp3.1]
/nix/store/x5dlj03vbd86yrwm2l1n4xlxm62z8rs5-dotnet-sdk-8.0.405/share/dotnet/sdk/8.0.405/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(154,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'osx-arm64'. [/private/tmp/nix-build-qbittorrent-cli-1.8.24285.1.drv-0/source/src/QBittorrent.CommandLineInterface/QBittorrent.CommandLineInterface.csproj::TargetFramework=netcoreapp3.1]

Seems like a fundamental limitation of the .NET version required by this, and does not seem like it could be fixed without upstream support... should it just be unsupported for this package?

GaetanLepage
GaetanLepage reviewed Jan 30, 2025
View reviewed changes
@pta2002 pta2002 requested a review from GaetanLepage January 30, 2025 10:39
@GaetanLepage GaetanLepage requested a review from drupol January 30, 2025 10:45
@GaetanLepage
Copy link
Contributor

GaetanLepage commented Jan 30, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376403

x86_64-linux

✅ 1 package built:
  • qbittorrent-cli

aarch64-linux

✅ 1 package built:
  • qbittorrent-cli

x86_64-darwin

✅ 1 package built:
  • qbittorrent-cli

GaetanLepage
GaetanLepage approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks !

@GaetanLepage GaetanLepage merged commit 485ead0 into NixOS:master Jan 30, 2025
25 of 27 checks passed
@pta2002 pta2002 deleted the push-yztzypqxmlpz branch January 30, 2025 11:24
@magneticflux-
Copy link
Contributor

magneticflux- commented Jan 31, 2025

Oh, you beat me to it and I only noticed when my rebase had conflicts! 😆

Hopefully when my PR (fedarovich/qbittorrent-cli#122) gets merged we can remove the hacky version flags and fix aarch64-darwin support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drupol drupol drupol approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pta2002 @GaetanLepage @magneticflux- @drupol