WIP: bun: init configHook and fetchDeps; bun: switch to finalAttrs from rec by Eveeifyeve · Pull Request #376299 · NixOS/nixpkgs

Eveeifyeve · 2025-01-24T04:52:21Z

Adds bun.fetchDeps & bun.configHook to bun and updates bun to 1.2.
Blocked by Mic92/nix-update#557 for nix-update-script's.
This pr will lead up to the building bun from source.

NOTE: If you have something to say in this pr please think about if it's spam, off-topic, has already been said (which may have a comment about why I have resolved it) or would be preferred to be a message in matrix, before commenting as this pr. As this pr is becoming big with a lot of people subscribed and I am trying to keep it organized, maintained and not ping heavy.

All related issues that it closes:

closes #335534
closes #255890
closes #414837
closes #424038

This work is semi sponsored by DigitalBrewStudios.

Things done

Add a 👍 reaction to pull requests you find important.

winterqt

To even begin reviewing this, this needs to be properly split up into multiple commits; ideally, the Bun upgrade would be done in a separate PR entirely.

pkgs/by-name/bu/bun/fetch-deps/bun-config-hook.sh

pkgs/by-name/bu/bun/fetch-deps/default.nix

getchoo · 2025-01-27T04:30:40Z

I am still keeping this draft for now, because of one waiting for #376054 to merged

Merged

pkgs/by-name/op/opencode/package.nix

Eveeifyeve · 2026-02-21T11:20:47Z

Just re-requesting for reviews that are outdated from the following reviewers or have been made a topic already about and have been marked resolve because it's a duplicate.

~~I am also cleaning up this pr for comments resolved, outdated or should have been asked in the matrix.~~ UPDATE: cleaned up and made a message nice an clear in pr description.

kuflierl · 2026-02-21T11:52:28Z

You do realise the code isn't evaluating right?

delafthi · 2026-02-21T12:20:45Z

pkgs/by-name/op/opencode/package.nix

+  bunWorkspaces = [ "./packages/opencode" ];
+  bunDeps = bun.fetchDeps {
+    inherit (finalAttrs)
+      pname
+      version
+      src
+      bunWorkspaces
+      ;
+    hash = "sha256-HGoeaGrrWYIuaI9yEQJNadCUmmsgFYiQW56ginUa1Bk=";


This change will probably break opencode-desktop since it inherits node_modules from opencode and depends on more than just ./packages/opencode. However, I'm currently not a fan of how opencode and opencode-desktop are two separate packages but depend so heavily on each other (both need to be updated at the same time).

The only thing that is breaking is opencode dependency out of this.
I will probably look into a separate hook for the bun deps for desktop still dependent on src and version from opencode. However probably best in a separate issue to separate the dependent of opencode version src and stuff and make it separate.

Only thing is left to do is fix opencode, so I do the hash for desktop.

Right, I just tested the build and got

specified: sha256-HGoeaGrrWYIuaI9yEQJNadCUmmsgFYiQW56ginUa1Bk= got: sha256-bxDOFMH70AivlhQpxbyDE+hI4372GveEGxjkEQGOA9w=

Even when it unpacks through that phase still broken as the tarball is not unpacking before it gets installed.

delafthi

opencode LGTM. Just added a comment about opencode-desktops dependency to opencode.

DuskyElf · 2026-02-21T17:16:11Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376299 --package opencode --package opencode-desktop
Commit: 7d44e4fcff590a2d7b05abc14fbb370b8ea54e05

`x86_64-linux`

❌ 2 packages failed to build:

opencode
opencode-desktop

error: hash mismatch in fixed-output derivation '/nix/store/zhx1rfqs5gaigv5h28fwbrm5whhwbgqb-opencode-desktop-1.2.9-bun-deps.tar.gz.drv':
         specified: sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=
            got:    sha256-NluoZOsWpt2gdUY69cOnCbmEdve6NoQOTglDDm6GsCM=
error: hash mismatch in fixed-output derivation '/nix/store/86w41zn9b5fc2riak7r5d2d03ar2z9h7-opencode-1.2.9-bun-deps.tar.gz.drv':
         specified: sha256-HGoeaGrrWYIuaI9yEQJNadCUmmsgFYiQW56ginUa1Bk=
            got:    sha256-e1Zio0/ifSbkODcFTGgrueopizTTBWXn5n3vg/Arcw4=

pyrox0

Found some grammar fixes and one small change I'd like to be made, or at least considered.

doc/languages-frameworks/javascript.section.md

pyrox0 · 2026-02-21T17:20:50Z

doc/languages-frameworks/javascript.section.md

+
+#### Dealing with CPU/OS specific dependencies {#javascript-bun-oscpu}
+
+Some bun dependencies may require OS or CPU architecture specific dependency variations. With the `os` and `cpu` attributes in `fetchDeps`, you can specify which to fetch. By default the fetcher will get all CPU architectures for linux, darwin and freebsd.


All other fetchers fetch all dependencies regardless of platform. Is this an option for bun? Making this non-configurable leads to fewer code paths and thus less room for error and bugs to creep in. Also, fetching only specified platforms means if we change some default "blessed" set of platforms, we'd have to regenerate all hashes that depend on that set, whereas fetching all platforms means that hashes won't change in those cases(because they would not exist due to there being no blessed set of platforms we fetch for by default)

The thing is that there is no such default. Bun will by default only pull dependencies for the current system. That makes the output non-deterministic. Also pulling in windows dependencies wouldn't make much sense as these take up a lot of space for nothing. But we also have nixpkgs pkgs that only support one arch or platform. It wouldn't make much sense to also pull in unused code.

These are in essence fetcher parameters and it is expected that the output will change when the input parameters change.

Other fetchers generally only fetch source code and not binaries and are plotform/os agnostic.

doc/languages-frameworks/javascript.section.md

RossSmyth · 2026-02-21T18:36:05Z

This should really use lib.extendMkDerivation and not makeOverridable and such.

pkgs/by-name/bu/bun/hooks/default.nix

RossSmyth · 2026-02-22T20:56:06Z

The FODs produced are not reproducible. The build fails if you do not have the FOD as it reports a different hash.

RossSmyth

Think very carefully about the public API. What should be able to be overriden? What shouldn't be? Making the public API as small as possible for the MVP is good because expanding it later is not a breaking change, while reducing it is.

Also giving this a try, the FODs are not reproducible as noted above.

pkgs/by-name/bu/bun/hooks/default.nix

RossSmyth · 2026-02-22T21:03:04Z

pkgs/by-name/bu/bun/hooks/default.nix

+          dontConfigure = args'.dontConfigure or true;
+          dontFixup = args'.dontFixup or true;
+
+          inherit outputHash outputHashAlgo;


Please actually think about this review instead of saying that is is complicated. It is making it more future-proof.

pkgs/by-name/bu/bun/hooks/default.nix

Eveeifyeve · 2026-02-22T23:14:36Z

The FODs produced are not reproducible. The build fails if you do not have the FOD as it reports a different hash.

For this I have the check with other apps that use bun and see if it's globally producing .npm files. Personally someone had a solution here, but I don't like the use of the arbitrary & seems malicious dd command personally, unless it's okay to use it for this case so I have asked @winterqt to review it, before I go ahead and add it.

There is also some known issues I am trying to fix before this like in the configHook it's not unpacking the tar correctly.

kuflierl · 2026-02-23T00:04:27Z

For this I have the check with other apps that use bun and see if it's globally producing .npm files. Personally someone had a solution here, but I don't like the use of the arbitrary & seems malicious dd command personally, unless it's okay to use it for this case so I have asked @winterqt to review it, before I go ahead and add it.

The dd command is just writing 4 bytes at offset 96 in the file. Which does fit very nicely with my diff where I found the difference at 0x60. This would be valid as long as we assume that the position of the timestamp is always at that static offset and that we are dealing with a 4 byte little endian encoded unix timestamp. Considering that there were 4 trailing 0 bytes, we might be dealing with an 8 byte value.

We definitely need to look into the binary format.

Also I don't expect the second command restoring the date to really work since it seems to try to read the current date via the date command.

kuflierl · 2026-02-23T03:51:16Z

pkgs/by-name/bu/bun/hooks/bun-config-hook.sh

+    # `bunDeps` should be a tarball
+    unpackFile "$bunDeps"
+    bunDepsCopy="$(realpath "$(stripHash "$bunDeps")")"
+
+    echo "Configuring bun store"
+
+    HOME=$(mktemp -d)
+    BUN_INSTALL_CACHE_DIR=$(mktemp -d)
+    export HOME BUN_INSTALL_CACHE_DIR
+
+    cp -Tr "$bunDepsCopy" "$BUN_INSTALL_CACHE_DIR"
+    chmod -R +w "$BUN_INSTALL_CACHE_DIR"


Why exactly are we creating 2 copies of the unpacked FOD? Couldn't we just unpack into a temp dir and point BUN_INSTALL_CACHE_DIR at it?

It needs to first unpack the deps to $bunDeps and then next line stripes the hash before it can be copied to the BUN_INSTALL_CACHE_DIR.

Hold on, aren't we unpacking from bunDeps to the current working directory? The location of the folder is then stored in bunDepsCopy where the content is then copied to Bun_install_cache_Dir.

This seems a bit unnecessarily complicated.

Why not something like this:

HOME=$(mktemp -d) pushd $(mktemp - d) unpackFile "$bunDeps" export BUN_INSTALL_CACHE_DIR="$(realpath "$(stripHash "$bunDeps")")" popd

It supposed to be unpacking to $bunDeps. The reason as to why it's not is because it doesn't have a root dir. Please have a look at @getchoo review if your unsure.

Which do you mean?

Which do you mean?

https://matrix.to/#/!CTCrFzsBPYmDLmrja4:0upti.me/$3zxkPY-g4_kIsRKc3F8NLO1l5pkte495X4zPWYkvn2U?via=nixos.org&via=matrix.org&via=tchncs.de

Eveeifyeve · 2026-02-23T06:46:10Z

pkgs/by-name/bu/bun/hooks/bun-config-hook.sh

+    fi
+
+    # `bunDeps` should be a tarball
+    unpackFile "$bunDeps"


Known problem: This is not unpacking to $bunDeps which is not correct in fetcher.

Co-authored-by: Winter <winter@winter.cafe> Co-authored-by: Seth Flynn <getchoo@tuta.io> Co-authored-by: kuflierl <41301536+kuflierl@users.noreply.github.com>

github-actions bot added 8.has: documentation This PR adds or changes documentation 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment labels Jan 24, 2025

nix-owners bot requested a review from winterqt January 24, 2025 04:54

Eveeifyeve marked this pull request as draft January 24, 2025 04:57

This comment was marked as spam.

Sign in to view

This comment was marked as outdated.

Sign in to view

github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 24, 2025

nix-owners bot requested review from 06kellyjac, DAlperin, cdmistman, diogomdp and thilobillerbeck January 24, 2025 05:00

Eveeifyeve force-pushed the bun-hooks branch 2 times, most recently from 5b658cf to fac0e2a Compare January 24, 2025 05:12

winterqt requested changes Jan 24, 2025

View reviewed changes

Eveeifyeve force-pushed the bun-hooks branch from fac0e2a to f1e994a Compare January 24, 2025 05:17

This comment was marked as outdated.

Sign in to view

Eveeifyeve mentioned this pull request Jan 24, 2025

Package request: Vibe #368788

Closed

Eveeifyeve force-pushed the bun-hooks branch from f1e994a to 1086aee Compare January 24, 2025 20:01

Eveeifyeve changed the title ~~bun: init configHook and fetchDeps; bun 1.1.43 -> 1.2.0~~ bun: init configHook and fetchDeps; bun 1.1.43 -> 1.2.0; bun: switch to finalAttrs from rec Jan 24, 2025

Eveeifyeve force-pushed the bun-hooks branch from 1086aee to bb19900 Compare January 24, 2025 22:29

winterqt requested changes Jan 24, 2025

View reviewed changes

pkgs/by-name/bu/bun/fetch-deps/bun-config-hook.sh Outdated Show resolved Hide resolved

pkgs/by-name/bu/bun/fetch-deps/default.nix Outdated Show resolved Hide resolved

Eveeifyeve force-pushed the bun-hooks branch 3 times, most recently from a72a721 to 30e4175 Compare January 25, 2025 11:31

This comment was marked as outdated.

Sign in to view

Eveeifyeve force-pushed the bun-hooks branch from 2210ce8 to 05f3501 Compare February 2, 2026 18:46

nixpkgs-ci bot requested review from delafthi, graham33 and kuflierl February 3, 2026 00:40

nixpkgs-ci bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 3, 2026

Eveeifyeve force-pushed the bun-hooks branch from 05f3501 to 193250c Compare February 5, 2026 05:17

nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 5, 2026

delafthi suggested changes Feb 11, 2026

View reviewed changes

pkgs/by-name/op/opencode/package.nix Show resolved Hide resolved

pkgs/by-name/op/opencode/package.nix Show resolved Hide resolved

pkgs/by-name/op/opencode/package.nix Show resolved Hide resolved

pkgs/by-name/op/opencode/package.nix Outdated Show resolved Hide resolved

nyabinary mentioned this pull request Feb 19, 2026

goofcord: 1.7.1 -> 2.0.1 #487177

Open

13 tasks

This comment was marked as resolved.

Sign in to view

delafthi reviewed Feb 21, 2026

View reviewed changes

delafthi approved these changes Feb 21, 2026

View reviewed changes

pyrox0 reviewed Feb 21, 2026

View reviewed changes

xiaoxiangmoe reviewed Feb 22, 2026

View reviewed changes

pkgs/by-name/bu/bun/hooks/default.nix Outdated Show resolved Hide resolved

RossSmyth suggested changes Feb 22, 2026

View reviewed changes

kuflierl reviewed Feb 23, 2026

View reviewed changes

Eveeifyeve commented Feb 23, 2026

View reviewed changes

Eveeifyeve and others added 4 commits February 23, 2026 18:53

bun: init configHook and fetchDeps;

b45ef19

Co-authored-by: Winter <winter@winter.cafe> Co-authored-by: Seth Flynn <getchoo@tuta.io> Co-authored-by: kuflierl <41301536+kuflierl@users.noreply.github.com>

cups-docker.passthru.web: switch to bun.fetchDeps and bun.configHook

9255651

WIP: opencode: switch to bun.fetchDeps and bun.configHook

448c66e

WIP: opencode-desktop: switch to use bun.fetchDeps and bun.configHook

a2e9c69


		#### Dealing with CPU/OS specific dependencies {#javascript-bun-oscpu}

		Some bun dependencies may require OS or CPU architecture specific dependency variations. With the `os` and `cpu` attributes in `fetchDeps`, you can specify which to fetch. By default the fetcher will get all CPU architectures for linux, darwin and freebsd.

Uh oh!

Conversation

Eveeifyeve commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All related issues that it closes:

Things done

Uh oh!

This comment was marked as spam.

This comment was marked as outdated.

winterqt left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Uh oh!

This comment was marked as outdated.

getchoo commented Jan 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Eveeifyeve commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kuflierl commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

delafthi Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Eveeifyeve Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

delafthi Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

delafthi left a comment

Choose a reason for hiding this comment

Uh oh!

DuskyElf commented Feb 21, 2026

nixpkgs-review result

x86_64-linux

Uh oh!

pyrox0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pyrox0 Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kuflierl Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RossSmyth commented Feb 21, 2026

Uh oh!

Uh oh!

RossSmyth commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RossSmyth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Eveeifyeve commented Jan 24, 2025 •

edited

Loading

Eveeifyeve commented Feb 21, 2026 •

edited

Loading

kuflierl commented Feb 21, 2026 •

edited

Loading

delafthi Feb 21, 2026 •

edited

Loading

Eveeifyeve Feb 21, 2026 •

edited

Loading

delafthi Feb 21, 2026 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

pyrox0 Feb 21, 2026 •

edited

Loading

kuflierl Feb 21, 2026 •

edited

Loading

RossSmyth commented Feb 22, 2026 •

edited

Loading

Eveeifyeve commented Feb 22, 2026 •

edited

Loading

kuflierl commented Feb 23, 2026 •

edited

Loading

Eveeifyeve Feb 23, 2026 •

edited

Loading