nixos/lib/test-driver: Revert magick args order#375858
Merged
K900 merged 1 commit intoNixOS:masterfrom Jan 23, 2025
Merged
Conversation
...as it apparently matters when we do the -negate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...as it apparently matters when we do the -negate
#375504 changed where the
-negatein the list ofmagickcommands for OCR pre-processing happens. This gets most OCR commands innixosTests.lomiri*tests stuck (i.e. the user name on the lightdm lomiri greeter innixosTests.lomiri.greeter, "Rotation Lock" in the lomiri settings app innixosTests.lomiri.{desktop-basics,desktop-appinteractions}).With the assumption that this was done for convenience instead of fixing any OCR issue in another setup, restore the original order of
magickargs.With #375365 applied to fix all required test dependencies, all of
nixosTests.lomiripasses again.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.