Skip to content

nixVersions.nix_2_24: 2.24.11 -> 2.24.12#375820

Merged
roberth merged 2 commits intomasterfrom
nix-2.24.12
Jan 27, 2025
Merged

nixVersions.nix_2_24: 2.24.11 -> 2.24.12#375820
roberth merged 2 commits intomasterfrom
nix-2.24.12

Conversation

@roberth
Copy link
Member

@roberth roberth commented Jan 22, 2025

Changes: NixOS/nix@2.24.11...2.24.12

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 22, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jan 22, 2025
@nix-owners nix-owners bot requested review from Artturin and lovesegfault January 22, 2025 13:09
@philiptaron
Copy link
Contributor

How can I help land new Nix versions more quickly, especially ones that impact the default version of Nix delivered on unstable, as this one does?

The present state of affairs -- a long list of reviewers, no reviews, no merges, and no pings -- seems sub-optimal. Let's get the hard work of the Nix team into the hands of the vast Nixpkgs community.

Is the problem that the PR only has minimal information about what's included in the release and what defects it fixes? Do we need a PR template for Nix releases that helps generate merge excitement through listing the issues fixed? Or is the list of reviewers and maintainers subject to RFC55, where it's a historical artifact rather than a present reality?

I'm a nixpkgs committer, but I feel a little less-than-empowered to just go ahead and merge in the face of this list of long-timers who may be intentionally taking no action for reasons I don't understand. 🙂

I'd like to be part of the solution. What's needed?

@philiptaron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375820


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • sonarr
⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
❌ 7 packages failed to build:
  • nixStatic
  • nixStatic.dev
  • nixStatic.doc
  • nixStatic.man
  • python313Packages.nix-kernel
  • python313Packages.nix-kernel.dist
  • zon2nix
✅ 148 packages built:
  • appvm
  • attic-client
  • attic-server
  • bower2nix
  • bundix
  • cabal2nix
  • cached-nix-shell
  • cachix (cachix.bin ,cachix.doc ,haskellPackages.cachix.bin)
  • chirpstack-concentratord
  • colmena
  • common-updater-scripts
  • crate2nix
  • crystal2nix
  • devenv
  • disko
  • dub-to-nix
  • dydisnix
  • fusionInventory
  • gcalcli
  • gcalcli.dist
  • glpi-agent
  • haskellPackages.cabal2nix-unstable
  • haskellPackages.cachix
  • haskellPackages.cachix.doc
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.hercules-ci-agent
  • haskellPackages.hercules-ci-agent.doc
  • haskellPackages.hercules-ci-cli
  • haskellPackages.hercules-ci-cli.doc
  • haskellPackages.hercules-ci-cnix-expr
  • haskellPackages.hercules-ci-cnix-expr.doc
  • haskellPackages.hercules-ci-cnix-store
  • haskellPackages.hercules-ci-cnix-store.doc
  • haskellPackages.niv
  • haskellPackages.niv.bin
  • haskellPackages.niv.data
  • haskellPackages.niv.doc
  • haskellPackages.nix-paths
  • haskellPackages.nix-paths.doc
  • haskellPackages.nix-serve-ng
  • haskellPackages.nix-serve-ng.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • hci
  • hercules-ci-agent
  • home-manager
  • hydra
  • hydra.doc
  • kcl
  • libnixxml
  • lua51Packages.luarocks-nix
  • luarocks-nix (luaPackages.luarocks-nix)
  • lua53Packages.luarocks-nix
  • lua54Packages.luarocks-nix
  • luajitPackages.luarocks-nix
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nim_lk
  • niv (niv.bin ,niv.data)
  • nix (nixVersions.nix_2_24 ,nixVersions.stable)
  • nix-bundle
  • nix-direnv
  • nix-du
  • nix-forecast
  • nix-index
  • nix-init
  • nix-inspect
  • nix-pin
  • nix-plugin-pijul
  • nix-plugins
  • nix-prefetch
  • nix-prefetch-bzr
  • nix-prefetch-cvs
  • nix-prefetch-docker
  • nix-prefetch-git
  • nix-prefetch-hg
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-required-mounts
  • nix-required-mounts.dist
  • nix-serve
  • nix-serve-ng
  • nix-template
  • nix-unit
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • nix-visualize
  • nix-visualize.dist
  • nix-web
  • nix.debug (nixVersions.nix_2_24.debug ,nixVersions.stable.debug)
  • nix.dev (nixVersions.nix_2_24.dev ,nixVersions.stable.dev)
  • nix.doc (nixVersions.nix_2_24.doc ,nixVersions.stable.doc)
  • nix.man (nixVersions.nix_2_24.man ,nixVersions.stable.man)
  • nixci
  • nixd
  • nixos-anywhere
  • nixos-generators
  • nixos-option
  • nixos-rebuild
  • nixos-rebuild-ng
  • nixos-rebuild-ng.dist
  • nixos-shell
  • nixpkgs-hammering
  • nixpkgs-manual
  • nixpkgs-review
  • nixpkgs-review.dist
  • nixt
  • nixt.dev
  • nixtract
  • node2nix
  • npins
  • nuget-to-json
  • nuget-to-nix
  • nurl
  • nvfetcher
  • outline
  • prefetch-yarn-deps
  • python312Packages.nix-kernel
  • python312Packages.nix-kernel.dist
  • sbomnix
  • sbomnix.dist
  • swiftpm2nix (swiftPackages.swiftpm2nix)
  • terranix
  • tests.devShellTools.nixos
  • tests.haskell.cabalSdist.hercules-ci-cnix-store
  • tests.haskell.cabalSdist.hercules-ci-cnix-store.doc
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example
  • tests.trivial-builders.references
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vimPlugins.typescript-tools-nvim
  • vimPluginsUpdater
  • vulnix
  • vulnix.dist
  • vulnix.doc
  • vulnix.man
  • wp4nix
  • yarn2nix

@philiptaron
Copy link
Contributor

I'm bisecting the nixStatic build failures. They also fail on Hydra for release-24.11!

@tomberek
Copy link
Contributor

I'd like to be part of the solution. What's needed?

This work you are doing to build, test, report issues is perfect! Thanks so much.

@Mic92
Copy link
Member

Mic92 commented Jan 27, 2025

I'm bisecting the nixStatic build failures. They also fail on Hydra for release-24.11!

This package often breaks because something else in nixpkgs breaks dependencies of nixStatic. It's quite often broken actually for this reason, so I have reasons to believe not many people actually want to use it.

@philiptaron
Copy link
Contributor

This package often breaks because something else in nixpkgs breaks dependencies of nixStatic. It's quite often broken actually for this reason, so I have reasons to believe not many people actually want to use it.

In a twist of fate, I need it for work reasons, so the bisection is doing double duty. You're right that it's broken by a dependency, and an odd one at that. I bisected it to c55530f, committed as #353968. It doesn't block this PR in any case.

Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All build failures are not this PR's fault. zon2nix fails on master, as does python313Packages.nix-kernel. Let's roll. 🚀

@roberth roberth merged commit e17fc16 into master Jan 27, 2025
34 of 36 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 27, 2025

Successfully created backport PR for release-24.11:

@eclairevoyant
Copy link
Contributor

This was a breaking change that should not have been backported.

$ nix shell github:nixos/nixpkgs/d114ef52edf12ffd5f661d6f261ccaeb6be6c261#nix -c nix repl
Nix 2.24.11
Type :? for help.
nix-repl> :lf git+https://codeberg.org/xmobar/xmobar.git/?dir=nix 
Added 17 variables.

$ nix shell github:nixos/nixpkgs/8de6f7a8a9fad2d4ca40db678e8ca784c698c62b#nix -c nix repl
Nix 2.24.12
Type :? for help.
nix-repl> :lf git+https://codeberg.org/xmobar/xmobar.git/?dir=nix 
fatal: https://codeberg.org/xmobar/xmobar.git/?dir=nix/info/refs not valid: could not determine hash algorithm; is this a git repository?
warning: could not read HEAD ref from repo at 'https://codeberg.org/xmobar/xmobar.git/?dir=nix', using 'master'
fatal: https://codeberg.org/xmobar/xmobar.git/?dir=nix/info/refs not valid: could not determine hash algorithm; is this a git repository?
warning: could not update mtime for file '/home/USER/.cache/nix/gitv3/17017v3r39a0a79y2qdri66x4p8fa2fm8b4x149gsh2sc0d6azl3/refs/heads/master': changing modification time of '"/home/USER/.cache/nix/gitv3/17017v3r39a0a79y2qdri66x4p8fa2fm8b4x149gsh2sc0d6azl3/refs/heads/master"' (using `utimensat`): No such file or directory
fatal: Refusing to point HEAD outside of refs/
warning: could not update cached head 'master' for 'https://codeberg.org/xmobar/xmobar.git/?dir=nix'
error:
       … while fetching the input 'git+https://codeberg.org/xmobar/xmobar.git/?dir=nix'

       error: resolving Git reference 'master': revspec 'master' not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants