rustc: mark broken for LLVM stdenv #375267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getchoo
added
6.topic: llvm/clang
github-actions
bot
added
6.topic: rust
getchoo
added
the
6.topic: llvm/clang
nix-owners
bot
requested review from
Mic92,
alyssais,
figsoda,
winterqt and
zowoq
alyssais
approved these changes
Jan 20, 2025
getchoo
added
the
12.approvals: 1
Contributor
|
Successfully created backport PR for |
1 task
Member
|
This PR isn't necessary as #330037 has been waiting for reviews since July and fixes the problem. |
Member
Author
It's great there is some work here to fix it, but I wouldn't call this unnecessary since until that (or an alternative) lands, this is broken |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build itself was fixed in #320432, but the compiler still tries to link with
libgcc_swhenever it's run (or just about :p). Marking this package as broken helps to avoid users coming across this when we already know it won't workContext:
#311930
#311930 (comment)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.